Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] fix: 조사 치환이 되지 않는 버그 수정 #722

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

chysis
Copy link
Contributor

@chysis chysis commented Sep 26, 2024


🚀 어떤 기능을 구현했나요 ?

  • 조사 치환이 되지 않는 버그를 수정했습니다.

🔥 어떻게 해결했나요 ?

  • value !== undefined!value로 수정한 것이 문제였습니다.

추가적으로, 바뀐 api 데이터에 맞게 목 데이터를 수정했습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

@chysis chysis added this to the 5차 스프린트 milestone Sep 26, 2024
@chysis chysis self-assigned this Sep 26, 2024
@chysis chysis linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link
Contributor

@BadaHertz52 BadaHertz52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꾿!!! 집에 가자!!!

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내일이 5차 데모데이인지라 많은 PR이 올라오네요😭 에프이 너무 수고했어요!

Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

참회합니다...

@ImxYJL ImxYJL merged commit 8a92c9d into develop Sep 26, 2024
5 checks passed
@donghoony donghoony deleted the fe/fix/717-bug branch September 26, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] 조사 치환이 되지 않는 버그를 해결한다.
4 participants