Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] fix: 선택하지 않은 체크박스는 응답하지 않도록 수정 #729

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[BE] fix: 선택하지 않은 체크박스는 응답하지 않도록 수정 #729

merged 1 commit into from
Sep 26, 2024

Conversation

donghoony
Copy link
Contributor

@donghoony donghoony commented Sep 26, 2024 •
edited
Loading

🚀 어떤 기능을 구현했나요 ?

  • 내려줄 때에는 체크한 내용만 내려주기

🔥 어떻게 해결했나요 ?

  • selectedOptionIds.contains로 확인했어요

테스트가 진행되어야겠네요 🤔 Mapper 테스트가 존재하지 않았어요.

image

@donghoony donghoony linked an issue Sep 26, 2024 that may be closed by this pull request
[BE] fix: 리뷰 상세보기 응답 시 체크하지 않은 항목은 반환하지 않도록 수정한다. #728
Closed
@github-actions GitHub Actions
Copy link

Test Results

102 tests   102 ✅  3s ⏱️
 36 suites    0 💤
 36 files      0 ❌

Results for commit e86f37b.

@donghoony donghoony self-assigned this Sep 26, 2024
skylar1220
skylar1220 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@skylar1220 skylar1220 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프론트랑 얘기해서 불필요한 isChecked 속성 제거합시당~

nayonsoso
nayonsoso approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@nayonsoso nayonsoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어푸어푸~

@donghoony donghoony merged commit 031c0f8 into develop Sep 26, 2024
6 checks passed
@donghoony donghoony deleted the be/fix/728-remove-non-selected-option branch September 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimprodp Kimprodp Kimprodp approved these changes

@skylar1220 skylar1220 skylar1220 approved these changes

@nayonsoso nayonsoso nayonsoso approved these changes

Assignees

@donghoony donghoony

Labels
✨ BE 🐛 버그 😱 긴급
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] fix: 리뷰 상세보기 응답 시 체크하지 않은 항목은 반환하지 않도록 수정한다.
4 participants
@donghoony @nayonsoso @skylar1220 @Kimprodp