Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] fix: 섹션에 해당하는 질문만 응답하도록 수정 #735

Merged
merged 2 commits into from
Sep 26, 2024
Merged

[BE] fix: 섹션에 해당하는 질문만 응답하도록 수정 #735

merged 2 commits into from
Sep 26, 2024

Conversation

donghoony
Copy link
Contributor

as-is:
image

to-be:
image

🔥 어떻게 해결했나요 ?

  • 각각의 클래스에 알맞은 메서드를 추가했습니다. 필터링 추가해서 섹션에 해당하는 질문만을 반환합니다.

@donghoony donghoony linked an issue Sep 26, 2024 that may be closed by this pull request
[BE] 리뷰 상세 조회에서 섹션 개수만큼 질문의 개수를 불러오는 버그를 수정한다. #733
Closed
@github-actions GitHub Actions
Copy link

Test Results

102 tests  ±0   102 ✅ ±0   3s ⏱️ ±0s
 36 suites ±0     0 💤 ±0 
 36 files   ±0     0 ❌ ±0 

Results for commit 7886f3a. ± Comparison against base commit 031c0f8.

nayonsoso
nayonsoso approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@nayonsoso nayonsoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바쁜 와중에도 메서드 분리를 통해서 깔끔한 코드를 작성했군요!
아루 짱짱입니다~

Kimprodp
Kimprodp approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼히 확인할게요!

skylar1220
skylar1220 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠구최
쿼리 나가는 건 천천히 볼게요!

@chysis
Copy link
Contributor

chysis commented Sep 26, 2024

파이팅!

@donghoony donghoony merged commit e597d6f into develop Sep 26, 2024
6 checks passed
@donghoony donghoony deleted the backend/fix/733-section-contains branch October 10, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimprodp Kimprodp Kimprodp approved these changes

@skylar1220 skylar1220 skylar1220 approved these changes

@nayonsoso nayonsoso nayonsoso approved these changes

Assignees
No one assigned
Labels
✨ BE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 리뷰 상세 조회에서 섹션 개수만큼 질문의 개수를 불러오는 버그를 수정한다.
5 participants
@donghoony @chysis @nayonsoso @skylar1220 @Kimprodp