Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] fix: Highlight 엔티티의 데이터 타입을 db 테이블와 일치시킨다. #829

Merged
merged 4 commits into from
Oct 11, 2024
Merged

[BE] fix: Highlight 엔티티의 데이터 타입을 db 테이블와 일치시킨다. #829

merged 4 commits into from
Oct 11, 2024

Conversation

skylar1220
Copy link
Contributor

🚀 어떤 기능을 구현했나요 ?

  • Highlight 엔티티의 데이터 타입을 db 테이블와 일치시킨다.

🔥 어떻게 해결했나요 ?

  • Highlight 엔티티의 lineIndex, startIndex, endIndex의 데이터 타입을 테이블과 일치하게 long→ int로 변경하였습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

@skylar1220 skylar1220 self-assigned this Oct 11, 2024
@skylar1220 skylar1220 linked an issue Oct 11, 2024 that may be closed by this pull request
[BE] 어플리케이션에서 하이라이트 엔티티의 데이터 타입을 db와 맞춰준다. #828
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

Test Results

146 tests  ±0   146 ✅ ±0   4s ⏱️ -1s
 55 suites ±0     0 💤 ±0 
 55 files   ±0     0 ❌ ±0 

Results for commit 25bb366. ± Comparison against base commit 7e5564b.

♻️ This comment has been updated with latest results.

donghoony
donghoony approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@donghoony donghoony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛🐛🐛🐛 자바는 int랑 long을... 😮‍💨

nayonsoso
nayonsoso approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@nayonsoso nayonsoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어푸루부입니다~~

Kimprodp
Kimprodp approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확완~

@skylar1220 skylar1220 merged commit 9a9d6de into develop Oct 11, 2024
4 checks passed
skylar1220 added a commit that referenced this pull request Nov 5, 2024
@skylar1220
[BE] fix: Highlight 엔티티의 데이터 타입을 db 테이블와 일치시킨다. (#829)
5b40cd5 
* fix: db와 데이터 타입 범위 일치를 위해 필드 타입 int을 변경

* refactor: dto의 인덱스 관련 데이터 타입을 int로 변경

* refactor: null을 처리하도록 DTO의 필드 데이터 타입을 Integer로 변경

* refactor: 불필요한 타입 캐스팅 제거
@donghoony donghoony deleted the be/fix/828-change-highlight-type-int branch November 17, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimprodp Kimprodp Kimprodp approved these changes

@nayonsoso nayonsoso nayonsoso approved these changes

@donghoony donghoony donghoony approved these changes

Assignees

@skylar1220 skylar1220

Labels
✨ BE 🐛 버그
Projects
2024-review-me
Status: Done
Milestone
6차 스프린트: 최종장
Development

Successfully merging this pull request may close these issues.

[BE] 어플리케이션에서 하이라이트 엔티티의 데이터 타입을 db와 맞춰준다.
4 participants
@skylar1220 @donghoony @nayonsoso @Kimprodp