Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] chore: 무중단 배포 개발 서버에 적용하는 cd 작성 #886

Merged
merged 3 commits into from
Oct 21, 2024
Merged

[BE] chore: 무중단 배포 개발 서버에 적용하는 cd 작성 #886

merged 3 commits into from
Oct 21, 2024

Conversation

nayonsoso
Copy link
Contributor

@nayonsoso nayonsoso commented Oct 20, 2024 •
edited
Loading

🚀 어떤 기능을 구현했나요 ?

무중단 배포에 필요한 cd 파일과 yml 파일을 만들어주었습니다. 😊
cd 파일의 전반적인 구조는 동일하나, 마지막 부분에서 아래 부분이 변경되었습니다.

- name: Deploy new version # 변경 부분
  env:
    PROFILE_VAR: "dev"
  run: |
    chmod +x ./deploy.sh
    sudo ./deploy.sh

  working-directory: ${{ env.APPLICATION_DIRECTORY }}/app

테스트용으로 만든것이기 때문에 원본에서 조금만 추가가 된 것임에도
원본을 해치지 않기 위해 파일 자체를 새로 만들어주었습니다 :)

위 내용은, 'deploy.sh' 파일을 실행하겠다는 뜻입니다.
deploy.sh 파일에 필요한 내용들은 요 PR에서 보실 수 있습니다

https://github.com/woowacourse-teams/2024-review-me-secret/pull/5

🔥 어떻게 해결했나요 ?

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

@nayonsoso nayonsoso linked an issue Oct 20, 2024 that may be closed by this pull request
[BE] 무중단 배포를 적용한다. #885
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 20, 2024 •
edited
Loading

Test Results

155 tests  ±0   152 ✅ ±0   5s ⏱️ -1s
 59 suites ±0     3 💤 ±0 
 59 files   ±0     0 ❌ ±0 

Results for commit f95b461. ± Comparison against base commit 834feff.

♻️ This comment has been updated with latest results.

donghoony
donghoony approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@donghoony donghoony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가보자가보자!

Kimprodp
Kimprodp approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

으악 어렵다

skylar1220
skylar1220 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저녁 먹기 전까지 적용 완료합니다~
그때까지 dev 셔터 내려요~~🚧

@skylar1220 skylar1220 merged commit 36df03d into develop Oct 21, 2024
3 checks passed
skylar1220 pushed a commit that referenced this pull request Nov 5, 2024
@nayonsoso @skylar1220
[BE] chore: 무중단 배포 개발 서버에 적용하는 cd 작성 (#886)
b8cf2c5 
* chore: 무중단 배포 설정

* chore: dev 서버 무중단 배포 cd 작성

* chore: cd 이름 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimprodp Kimprodp Kimprodp approved these changes

@skylar1220 skylar1220 skylar1220 approved these changes

@donghoony donghoony donghoony approved these changes

Assignees

@nayonsoso nayonsoso

@skylar1220 skylar1220

Labels
✨ BE 🌏 인프라
Projects
2024-review-me
Status: Done
Milestone
6차 스프린트: 최종장
Development

Successfully merging this pull request may close these issues.

[BE] 무중단 배포를 적용한다.
4 participants
@nayonsoso @donghoony @skylar1220 @Kimprodp