Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] - 삭제 및 등록 시 여러번 요청하지 못하게 수정 #295

Merged
merged 5 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import TravelPlanDetailSkeleton from "@components/pages/travelPlanDetail/TravelP
import TravelPlansTabContent from "@components/pages/travelPlanDetail/TravelPlansTabContent/TravelPlansTabContent";

import useClickAway from "@hooks/useClickAway";
import useLeadingDebounce from "@hooks/useLeadingDebounce";

import { ERROR_MESSAGE_MAP } from "@constants/errorMessage";
import { ROUTE_PATHS_MAP } from "@constants/route";
Expand All @@ -30,11 +31,9 @@ import * as S from "./TravelPlanDetailPage.styled";

const TravelPlanDetailPage = () => {
const location = useLocation();

const { onTransformTravelDetail } = useTravelTransformDetailContext();

const id = extractId(location.pathname);

const { onTransformTravelDetail } = useTravelTransformDetailContext();
const { data, status, error } = useGetTravelPlan(id);

const navigate = useNavigate();
Expand Down Expand Up @@ -69,8 +68,10 @@ const TravelPlanDetailPage = () => {
setIsDeleteModalOpen((prev) => !prev);
};

const debouncedClickDeleteButton = useLeadingDebounce(() => deleteTravelPlan(Number(id)), 3000);

const handleClickDeleteButton = () => {
deleteTravelPlan(Number(id));
debouncedClickDeleteButton();
};

//TODO: 수정 이벤트 추가해야함
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import Calendar from "@components/common/Calendar/Calendar";
import TravelPlanDayAccordion from "@components/pages/travelPlanRegister/TravelPlanDayAccordion/TravelPlanDayAccordion";

import { useTravelPlanDays } from "@hooks/pages/useTravelPlanDays";
import useLeadingDebounce from "@hooks/useLeadingDebounce";
import useUser from "@hooks/useUser";

import { ERROR_MESSAGE_MAP } from "@constants/errorMessage";
Expand Down Expand Up @@ -62,7 +63,7 @@ const TravelPlanRegisterPage = () => {

const navigate = useNavigate();

const handleConfirmBottomSheet = async () => {
const handleRegisterTravelPlan = () => {
const formattedStartDate = startDate
? new Date(startDate.getTime() - startDate.getTimezoneOffset() * 60000)
.toISOString()
Expand All @@ -78,8 +79,12 @@ const TravelPlanRegisterPage = () => {
},
},
);
};

const debouncedRegisterTravelPlan = useLeadingDebounce(() => handleRegisterTravelPlan(), 3000);

handleCloseBottomSheet();
const handleConfirmBottomSheet = () => {
debouncedRegisterTravelPlan();
};

const { mutate: handleAddTravelPlan } = usePostTravelPlan();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import TravelogueDetailSkeleton from "@components/pages/travelogueDetail/Travelo
import TravelogueTabContent from "@components/pages/travelogueDetail/TravelogueTabContent/TravelogueTabContent";

import useClickAway from "@hooks/useClickAway";
import useLeadingDebounce from "@hooks/useLeadingDebounce";
import useUser from "@hooks/useUser";

import { ROUTE_PATHS_MAP } from "@constants/route";
Expand Down Expand Up @@ -58,8 +59,10 @@ const TravelogueDetailPage = () => {
setIsDeleteModalOpen((prev) => !prev);
};

const debouncedClickDeleteButton = useLeadingDebounce(() => deleteTravelogue(Number(id)), 3000);

const handleClickDeleteButton = () => {
deleteTravelogue(Number(id));
debouncedClickDeleteButton();
};

//TODO: 수정 이벤트 추가해야함
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import TravelogueDayAccordion from "@components/pages/travelogueRegister/TravelogueDayAccordion/TravelogueDayAccordion";

import { useTravelogueDays } from "@hooks/pages/useTravelogueDays";
import useLeadingDebounce from "@hooks/useLeadingDebounce";
import useUser from "@hooks/useUser";

import { ERROR_MESSAGE_MAP } from "@constants/errorMessage";
Expand Down Expand Up @@ -78,8 +79,8 @@

const navigate = useNavigate();

const handleConfirmBottomSheet = () => {
handleRegisterTravelogue(
const handleRegisterTravelogue = () => {
registerTravelogueMutate(
{ title, thumbnail, days: travelogueDays },
{
onSuccess: (data) => {
Expand All @@ -90,7 +91,13 @@
);
};

const { mutate: handleRegisterTravelogue } = usePostTravelogue();
const debouncedRegisterTravelogue = useLeadingDebounce(() => handleRegisterTravelogue(), 3000);

const handleConfirmBottomSheet = () => {
debouncedRegisterTravelogue();
};

const { mutate: registerTravelogueMutate } = usePostTravelogue();

const { user } = useUser();

Expand All @@ -105,7 +112,7 @@
return () => {
saveTransformDetail(null);
};
}, [user?.accessToken, navigate]);

Check warning on line 115 in frontend/src/components/pages/travelogueRegister/TravelogueRegisterPage.tsx

View workflow job for this annotation

GitHub Actions / frontend-ci

React Hook useEffect has a missing dependency: 'saveTransformDetail'. Either include it or remove the dependency array

return (
<>
Expand Down
34 changes: 34 additions & 0 deletions frontend/src/hooks/useLeadingDebounce.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { useEffect, useRef } from "react";

const useLeadingDebounce = (callback: () => void, delay: number) => {
const isDebouncing = useRef(false);
const timeoutRef = useRef<ReturnType<typeof setTimeout>>();

const debouncedCallback = () => {
const isDebounceReady = !isDebouncing.current;
const isExistingTimerActive = isDebounceReady && timeoutRef.current;

if (isExistingTimerActive) clearTimeout(timeoutRef.current);

if (isDebounceReady) {
callback();
isDebouncing.current = true;

timeoutRef.current = setTimeout(() => {
isDebouncing.current = false;
}, delay);
}
};

useEffect(() => {
return () => {
if (timeoutRef.current) {
clearTimeout(timeoutRef.current);
}
};
}, []);

return debouncedCallback;
};

export default useLeadingDebounce;
Loading