[Feature] - 여행 계획 등록 페이지 접근성 개선 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Calendar 내 esc를 눌렀을 때 닫히도록 변경 2. visual hidden 텍스트 추가
1. 현재 년, 월에 대한 텍스트를 스크린 리더기가 읽도록 변경 2. 이전 버튼, 다음 버튼에 대한 설명 추가 3. Visual hidden 텍스트를 통해 이전 달로 이동할 수 없는 경우에 대한 안내 메시지 추가
EditRegisterModalBottomSheet 내 isOpen 시 렌더링 되도록 변경
Test Results11 tests 11 ✅ 14s ⏱️ Results for commit 860512c. ♻️ This comment has been updated with latest results. |
simorimi
approved these changes
Oct 23, 2024
Comment on lines
+24
to
+35
| export const visualHiddenStyle = css` | ||
| overflow: hidden; | ||
| position: absolute; | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| padding: 0; | ||
| border: 0; | ||
|
|
||
| white-space: nowrap; | ||
| clip: rect(0, 0, 0, 0); | ||
| `; |
There was a problem hiding this comment.
이 부분은 리버가 VisualHidden 컴포넌트를 구현했더라고요 이후에 합치면 좋을 거 같아요!
Comment on lines
+83
to
+95
|
|
||
| export const visualHiddenStyle = css` | ||
| overflow: hidden; | ||
| position: absolute; | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| padding: 0; | ||
| border: 0; | ||
|
|
||
| white-space: nowrap; | ||
| clip: rect(0, 0, 0, 0); | ||
| `; |
Comment on lines
+34
to
+45
| export const visualHiddenStyle = css` | ||
| overflow: hidden; | ||
| position: absolute; | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| padding: 0; | ||
| border: 0; | ||
|
|
||
| white-space: nowrap; | ||
| clip: rect(0, 0, 0, 0); | ||
| `; |
Comment on lines
+76
to
+87
| export const visualHiddenStyle = css` | ||
| overflow: hidden; | ||
| position: absolute; | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| padding: 0; | ||
| border: 0; | ||
|
|
||
| white-space: nowrap; | ||
| clip: rect(0, 0, 0, 0); | ||
| `; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용
접근성 lighthouse before & after
before
after
lighthouse의 경우 색상 대비율 문제만 존재해서 점수 변화는 없는 상태입니다.
📸 스크린샷
2024-10-21.5.54.32.1.mov
🙈 참고 사항
x