Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring 경로 조회 - 1단계] 레넌(조형래) 미션 제출합니다. #183

Merged
merged 28 commits into from
May 18, 2022

Conversation

brorae
Copy link

@brorae brorae commented May 17, 2022

안녕하세요. 루피 :)
블랙잭 미션에 이어 또 만나게 되었네요.
이번 미션도 리뷰 잘 부탁드리겠습니다!

jinyoungchoi95 and others added 28 commits May 17, 2022 14:10
Copy link

@TheDevLuffy TheDevLuffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레넌 안녕하세요~

리뷰어 루피입니다. 코드를 받았는데 이전 도메인 객체 변경을 최소화하여 잘 구현해주셨네요.
군더더기 없이 새로운 요구사항을 잘 추가해주신 것 같아요.

고민해보면 좋을 포인트에 몇 가지 코멘트 남겨두었는데요.
2단계 리뷰 요청에서 반영하여 PR 보내주세요.

너무 잘 구현해주셨습니다 👍
2단계에서 뵈어요 !

}

private int calculateOverFare(int distance, int unitDistance) {
return (int) ((Math.ceil((distance - 1) / unitDistance) + 1) * UNIT_OF_ADDITIONAL_FARE);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각 1이 어떤 의미인지 표현해주시면 좋을 것 같아요

@TheDevLuffy TheDevLuffy merged commit 3592bd9 into woowacourse:brorae May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants