[JDBC 라이브러리 구현하기 - 2단계] 에버(손채영) 미션 제출합니다. #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jminkkk
approved these changes
Oct 11, 2024
Comment on lines
+5
to
+8
| @FunctionalInterface | ||
| public interface ConsumerWrapper<T> { | ||
| void accept(T t) throws SQLException; | ||
| } |
Comment on lines
+107
to
+110
| Read Uncommitted : [발생] 커밋되지 않은 데이터도 접근 가능하므로 | ||
| Read Committed : [발생] 커밋된 데이터 접근 가능하므로 | ||
| Repeatable Read : [미발생] 동일한 행을 여러번 읽어도 같은 결과를 보장하므로 | ||
| Serializable : [미발생] 모든 읽기/쓰기 동작을 잠그므로 |
| @@ -70,7 +68,7 @@ void noPoling() throws SQLException { | |||
|
|
|||
| // 테스트 결과를 확인한다. | |||
| log.info("Elapsed runtime: {}", ClockSource.elapsedDisplayString(start, end)); | |||
| } | |||
| } // 11s 963ms | |||
Comment on lines
+127
to
+128
| // 주석 있는 경우: 물리적 트랜잭션 2개이지만, 두번째 트랜잭션은 사용 X | ||
| // 주석 없는 경우: 물리적 트랜잭션 1개이지만 사용 X (saveSecondTransactionWithNotSupported) |
There was a problem hiding this comment.
물리적 트랜잭션은 언제 동작할까요?
또 물리적 트랜잭션을 어떻게 확인할 수 있을까요?
There was a problem hiding this comment.
다음 단계에서 관련하여 답변 드리겠습니다!
Comment on lines
+48
to
+53
| private static void executeSql(String sql, Statement statement) throws SQLException { | ||
| String[] queries = sql.split(DELIMITER_OF_QUERY); | ||
| for (String query : queries) { | ||
| statement.addBatch(query); | ||
| } | ||
| statement.executeBatch(); |
There was a problem hiding this comment.
순차 실행으로 변경하셨군요!
allowMultiQueries=true 옵션을 줘서 동시 실행이 가능하도록 변경할 수도 있습니다.
알아만 두시죠 ㅎㅎ
private static DataSource createMySQLDataSource(final JdbcDatabaseContainer<?> container) {
final var config = new HikariConfig();
config.setJdbcUrl(container.getJdbcUrl() + "?allowMultiQueries=true");
config.setUsername(container.getUsername());
config.setPassword(container.getPassword());
config.setDriverClassName(container.getDriverClassName());
return new HikariDataSource(config);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
몰리 안녕하세요 ~
2단계 리팩터링 진행 후 리뷰 요청 드립니다 :)
LMS에서 제시하는 리팩터링 요소들을 1단계에서 많이 충족시켜서,
이번 단계에서는 중복 로직을 최대한 추출하려고 노력했어요.
추가로 리팩터링 요소 보이시면 마구 말씀해주세요!
이번 단계도 잘 부탁드립니다. 감사해요 😊