Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2단계 - 사다리 게임] 에버(손채영) 미션 제출합니다. #408
[2단계 - 사다리 게임] 에버(손채영) 미션 제출합니다. #408
Changes from 54 commits
2df96df
2fd81f2
e93f2fc
13613fc
c38f3fe
1e0448c
fb9b37c
99daf5b
4911b06
5a5628d
c9f0918
e0ff233
2102a7b
2c3c901
facd52d
beeef31
f910203
1dd91dd
ce49a3b
803e167
ed1f1a1
9748681
8d4519c
3a47aee
c9cd9f5
d47f231
1111cf5
fe27c4e
3c16742
d2e8627
04f84d0
5593b5e
21c7749
d16073e
88bac51
de2aae2
8150934
43de917
846cf65
de79f99
35fcabd
383377c
0f55255
0ef6218
7118a36
b2b9cc5
aabdef1
1bd1c79
57cd2a7
855c812
b0da8e1
b8f8ba6
742a584
0c1b40c
af3d268
cbae669
010a7d7
3258ff9
ff4ef9f
6f957d0
8abe223
9d1d287
2c189ae
8b03eb1
199bc66
9089a1e
29840d2
006cf63
ad0a4ef
b57d70d
0ee1469
209d116
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메소드의 시그니처만 보았을 때 String으로 되어있는 key가 어떤걸 의미하는지 알 수 없을 것 같아요.
Map으로 응답해도 괜찮을까요? 어떻게 응답을 주면 의미가 명확해질까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사실 구현하면서도 Member로 반환할지 String으로 반환할지와,
Map으로 반환할지 새로운 객체로 감싸 반환할지 고민을 하였습니다.
고민의 결과, 객체로 포장할 경우 출력 과정에서 불필요하게 추가되는 로직이 많을 것이라고 판단하였습니다.
또한 포장하지 않을 경우의 테스트 작성이 더욱 원활하여 위와 같이 반환하도록 결정하였습니다.
하지만 지금 다시 생각해보니, 불명확한 의미와 유지보수의 어려움이 문제가 될 것 같습니다.
따라서 오직 도메인 간 전달만을 위한 DTO 클래스를 새로 생성하고,
어려워진 테스트를 해결하기 위해서 Member와 MemberName의 equals를 재정의하였습니다!
This file was deleted.
This file was deleted.