Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1단계 - 사다리 생성] 허브(방대의) 미션 제출합니다. #97

Merged
merged 30 commits into from
Feb 16, 2023

Conversation

greeng00se
Copy link
Member

안녕하세요 터틀 🐢
전 허브라고 합니다. 🌿 잘부탁드립니다!

사다리의 경우 Ladder(사다리) -> Line(가로 라인) -> LineStatus(연결됨, 연결되지 않음)으로 구성을 했습니다.

부족한 부분이나 개선을 하면 좋겠다고 생각하시는 부분에 대해 리뷰 남겨주시면 적극적으로 반영 하겠습니다! 감사합니다 😄

greeng00se and others added 30 commits February 14, 2023 16:43
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Co-authored-by: wugawuga <dnr3655@naver.com>
Copy link
Member

@begaonnuri begaonnuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 허브 🌿

TDD로 진행하는 미션이라 쉽지 않으셨을텐데 잘 구현해주셨네요 💯
혹시나 은연중에 놓친 부분이 있을까 여러번 훑어보았는데도 빈 틈 없이 잘 해주셔서 이정도면 충분하다고 생각이 드네요.
커밋 로그도 봤는데 TDD 또한 잘 수행해주신게 드러나더라구요 👍🏻
아쉽지만(?) 이번 미션은 바로 머지하겠습니다. 고생하셨습니다!

질문을 PR에 남기려다 머뭇거리신 부분이 있었다면 편하게 DM주세요😊

Ladder --> Line
Line --> LineStatus
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기능목록을 상세하게 잘 작성해주셨네요 👍🏻

Comment on lines +3 to +5
public interface BooleanGenerator {
boolean generate();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인터페이스 추출 👍🏻

Comment on lines +28 to +32
final LadderGame ladderGame = initialize();
final List<String> players = ladderGame.getPlayers();
final List<Line> ladder = ladderGame.getLadder();

outputView.printResult(players, ladder);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View를 깔끔하게 잘 분리해주셨네요 👍🏻

@begaonnuri begaonnuri merged commit 6d246ae into woowacourse:greeng00se Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants