[1단계 - 페이먼츠] - 버건디(전태헌) 미션 제출합니다. #343
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import styled from 'styled-components'; | ||
|
|
||
| type InputProps = { | ||
| value: string; | ||
| onChange: (e: React.ChangeEvent<HTMLInputElement>) => void; | ||
| type: 'text' | 'number' | 'email' | 'password'; | ||
| placeholder: string; | ||
| id: string; | ||
| }; | ||
|
|
||
| const StyledInput = styled.input` | ||
|
There was a problem hiding this comment. 앗 처음에 아마 이렇게 작성하고 컨벤션을 놓친 컴포넌트들이 많을거 같은데요..! 한번 검토해보면서 수정해보겠습니다! 짚어주셔서 감사해요 하루~! |
||
| border: 1px solid rgba(172, 172, 172, 1); | ||
| padding: 8px; | ||
| font-size: 0.6875rem; | ||
| border-radius: 2px; | ||
| height: 32px; | ||
| `; | ||
|
|
||
| export default function Input({ value, onChange, type, placeholder, id }: InputProps) { | ||
| return ( | ||
| <StyledInput value={value} onChange={onChange} type={type} placeholder={placeholder} id={id} /> | ||
| ); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React.InputHTMLAttributes<HTMLInputElement>와 같이 제공되는 타입을 활용해서 타이핑하면 어떨까요? 혹은 의도해주신 걸까요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 아뇨 생각해보지 못한 부분입니다!
짚어주셔서 감사합니다 하루 🙇
한번 적용시켜보겠습니다~!