-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2단계 - 페이먼츠] 렛서(김다은) 미션 제출합니다. #390
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
2c1fd73
refactor: errMsg -> errorMessage로 이름 변경
llqqssttyy 1b9ab8c
refactor: 중복으로 관리되던 state 제거 및 validation 중복 로직 개선
llqqssttyy 738d50c
feat: 카드사 입력 필드 추가
llqqssttyy c297b8b
refactor: Input 컴포넌트 타입 분리
llqqssttyy a221f66
feat: CVC 번호 입력 필드 추가
llqqssttyy 570dd43
feat: cvc 번호 유효성 검사
llqqssttyy 5bcb0bc
feat: 비밀번호 입력 필드
llqqssttyy d2ddd59
chore: #app의 height 정의 제거
llqqssttyy a339f15
feat: 카드 뒤집기 기능 추가
llqqssttyy 3f785c9
feat: 카드 프리뷰에 cvc 번호 추가
llqqssttyy 6f53d2d
refactor: getCardBrand 함수를 CardPreview 컴포넌트와 분리
llqqssttyy f185ec3
refactor: 카드사 선택에 따라 카드 프리뷰의 배경색이 바뀌는 기능
llqqssttyy 81d4284
feat: 입력이 완료되면 다음 input으로 자동 포커싱되는 기능
llqqssttyy 8537f50
refactor: 다음 필드 노출에 관한 정보를 담고 있는 상태 이름 변경 및 역할 분리
llqqssttyy d49c1f4
chore: 주석 제거
llqqssttyy 9ea917d
refactor: useFormFieldFocus 훅의 매개변수로 길이를 받는 것으로 수정
llqqssttyy 5d869b4
feat: 폼 제출 버튼 추가 및 라우팅
llqqssttyy a422959
refactor: 폼 전체의 유효성과 입력 진행 상황을 context에 추가
llqqssttyy 0bc8d8b
feat: 등록 완료 페이지 추가
llqqssttyy b905bbf
fix: 비밀번호 입력 시 카드가 돌아가지 않는 버그
llqqssttyy 9b007bd
feat: NotFound 페이지 추가
llqqssttyy ed93da3
test: 입력 필드 및 버튼 스토리 추가
llqqssttyy 327af1d
test: Button 스토리 args 수정
llqqssttyy dd8ea71
chore: 불필요한 import 및 주석 제거
llqqssttyy 1700782
fix: 만료 날짜 값이 없을 때 예외처리
llqqssttyy 16096a6
fix: 타입 에러 수정
llqqssttyy 9d8bc6d
chore: Storybook에 스타일 파일 임포트
llqqssttyy 3d2ff54
chore: Select의 isRequired 기본값 주석 추가
llqqssttyy 3fad8c2
refactor: 하나의 인풋을 가지는 필드의 name을 미리 선언해 타입 단언 없애기
llqqssttyy ee884af
refactor: early return으로 조건부 렌더링 명시하기
llqqssttyy b54c3d3
refactor: Password 컴포넌트 early return 조건부 렌더링 명시
llqqssttyy fa747e2
refactor: 핸들러 명명 체계 수정
llqqssttyy 8fda2b2
refactor: INITIAL_VALUES 상수 타입 선언
llqqssttyy 3ba23c2
chore: Button theme css 클래스 적용 및 스타일 변경
llqqssttyy b340eac
refactor: 카드 정보를 params로 전달하는 대신 state에 전달하도록 수정
llqqssttyy 90c104b
feat: useAddCardFormContext에서 에러 발생 시 에러 페이지 노출
llqqssttyy dda438b
refactor: 필드에 전달되는 initial value에 대한 상수화 제거
llqqssttyy fdcfb6e
refactor: 변경된 핸들러 이름을 스토리북 코드에 적용
llqqssttyy 9546f6a
refactor: 변경된 핸들러 이름을 select 스토리북 코드에 적용
llqqssttyy 85100e7
refactor: useFormFieldFocus 내 useEffect 사용을 제거
llqqssttyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import '../src/index.css'; | ||
import type { Preview } from '@storybook/react'; | ||
|
||
const preview: Preview = { | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 이친구가 범인이었군요 👮🏻