Add HTTP status code to kitsu responses #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bglimepoint
force-pushed
the
add-status-code-to-response
branch
from
f158326 to
08a5d46
Compare
wopian
approved these changes
Dec 30, 2024
wopian
requested changes
Dec 30, 2024
This allows looking for status codes like 206 to know it's a partial response.
bglimepoint
force-pushed
the
add-status-code-to-response
branch
from
5f38523 to
b8d41ee
Compare
|
Thanks @wopian! Have updated the PR - including adding the status code to the other request types, but happy to adjust however you'd like :-) |
|
Thank you! These changes look great! After looking over it again I've opted to keep it the same as the property exposed by Axios ( |
wopian
approved these changes
Jan 3, 2025
wopian
changed the title
Kitsu.prototype.request.
|
Code Climate has analyzed commit fa19526 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
wopian
added a commit
that referenced
this pull request
Jan 3, 2025
* Add status code to the result of `Kitsu.prototype.request`. This allows looking for status codes like 206 to know it's a partial response. * refactor: replace statusCode with status --------- Co-authored-by: James Harris <3440094+wopian@users.noreply.github.com>
|
The changes have been released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for Kitsu! It's awesome :-)
We wanted to know whether the HTTP status code was a 206 to know if we'd received a partial response - and were wondering if you'd be willing to land this tweak to add it to the result :-)
Also, on looking a bit closer, I noticed that this isn't in the other methods in the same file - would be willing to add it more places if that's helpful 🙂