Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patch 2.01 + script compilation #31

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Fix patch 2.01 + script compilation #31

merged 3 commits into from
Oct 7, 2023

Conversation

psiberx
Copy link
Contributor

@psiberx psiberx commented Oct 4, 2023

Fixes script compilation when REDmod is used.

@psiberx psiberx changed the title Fix script compilation Fix patch 2.01 + script compilation Oct 5, 2023
Copy link

@alghaibb alghaibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't mind trying this out to see if it works

@psiberx psiberx marked this pull request as draft October 5, 2023 16:08
@psiberx psiberx marked this pull request as ready for review October 5, 2023 17:03
@giovankes
Copy link

@psiberx do you have the updated files somehwere? i can't seem to build it for some reason

@extract
Copy link

extract commented Oct 5, 2023

do you have the updated files somehwere? i can't seem to build it for some reason

If you need the built files they are available in github actions

https://github.com/WopsS/RED4ext/actions

But be aware that it's not working yet.

And not to be rude but avoid adding unrelated comments to this pull request!

@giovankes
Copy link

do you have the updated files somehwere? i can't seem to build it for some reason

If you need the built files they are available in github actions

https://github.com/WopsS/RED4ext/actions

But be aware that it's not working yet.

oh shit u fast af , thank u so much. then i'll wait until it works

Copy link

@HGinnerup HGinnerup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails with 'RED4EXT_RUNTIME_2_01': undeclared identifier

Replacing (aVersion == RED4EXT_RUNTIME_2_01) with true, still gets blocked by Image::IsSupported() returning false.

Making Image::IsSupported() always return true, makes the game attempt to load, but seemingly crashes when it gets to the first mod, though it may just be that ArchiveXL also needs to update something.

[2023-10-05 20:36:21.983] [RED4ext] [info] RED4ext (v0.0.0+master.d4b3262.20231005T180444Z) is initializing...
[2023-10-05 20:36:21.983] [RED4ext] [info] Game patch: 2.01
[2023-10-05 20:36:21.983] [RED4ext] [info] Product version: 2.01
[2023-10-05 20:36:21.983] [RED4ext] [info] File version: 3.0.74.63017
[2023-10-05 20:36:22.067] [RED4ext] [info] RED4ext has been successfully initialized
[2023-10-05 20:36:22.146] [RED4ext] [info] RED4ext is starting up...
[2023-10-05 20:36:22.146] [RED4ext] [info] Loading plugins...
[2023-10-05 20:36:22.147] [RED4ext] [info] Loading plugin from '[...]\Cyberpunk 2077\red4ext\plugins\ArchiveXL\ArchiveXL.dll'...

@@ -259,6 +259,10 @@ std::wstring Utils::FileVerToPatch(const RED4ext::FileVer& aVersion)
{
return L"2.00";
}
else if (aVersion == RED4EXT_RUNTIME_2_01)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fails with
identifier "RED4EXT_RUNTIME_2_01" is undefined

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need the submodule updated with wopss/RED4ext.SDK#92 ... just wait.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you're right. Updated the submodule as well, and it seems to work.

@wopss wopss mentioned this pull request Oct 5, 2023
Copy link
Owner

@wopss wopss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wopss wopss merged commit 808bbb0 into wopss:master Oct 7, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants