Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the license from GPL v2 to MPL v2 #1305

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Sep 14, 2020

All contributors agreed for the license switch in the ticket #1299 . We're now changing the license from GPL v2 to MPL v2.

@maxme maxme force-pushed the issue/license-switch-to-MPLv2 branch from 40ffa42 to 3dd803c Compare September 14, 2020 14:18
@hypest
Copy link

hypest commented Sep 14, 2020

Looks good so far @maxme!

I see a mention of the older LICENSE file in

FF5B98E41DC355B400571CA4 /* LICENSE */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = LICENSE; sourceTree = SOURCE_ROOT; };
, perhaps we need to open the project in Xcode to update the project file?

@hypest
Copy link

hypest commented Sep 14, 2020

Also, it seems that the README file is displaying an icon for the license file and picks it up from CocoaPods so, I guess we'll need to push the Pod to CocoaPods before the proper icon is shown in the final README. It shouldn't be a blocker for the PR though.

@maxme
Copy link
Contributor Author

maxme commented Sep 14, 2020

, perhaps we need to open the project in Xcode to update the project file?

Fixed in c3ddcde

It shouldn't be a blocker for the PR though.

I agree, let's merge this one and then push a new release to CocoaPods.

Copy link

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants