Fix unit tests failing in Xcode 15 #1382
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
These tests fail in CI, 15.0.1:
Locally, on my Xcode 15.2, this other test fails, and only that:
The Xcode 15.2 test fails because of a different space in the output:
The following diff fixes the issue, but it would be good to get to the bottom of it, right?
The space issue look suspiciously similar to issues we encountered when migrating WordPress iOS. See wordpress-mobile/WordPress-iOS@49aedbb#diff-d0661df56dbfd6db7932a214bcaf9b0861007eee71a73562fc326176a5475439L41-R54
There, we noticed a formatter going from
(the regular space) to
\u{202F}
. I tried it in the code failing on Xcode 15.2, but it didn't help. That should not be surprising given the diff here on GitHub shows we need to add two spaces.CHANGELOG.md
if necessary.