-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Xcode 15.3 in CI #1392
base: tooling/fix-sync-pod-publication
Are you sure you want to change the base?
Use Xcode 15.3 in CI #1392
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dccf8ef - Browse repository at this point
Copy the full SHA dccf8efView commit details -
Address an access control warning
> Non-'@objc' instance method in extensions cannot be overridden; > use 'public' instead
Configuration menu - View commit details
-
Copy full SHA for afc4064 - Browse repository at this point
Copy the full SHA afc4064View commit details -
Configuration menu - View commit details
-
Copy full SHA for 168f40e - Browse repository at this point
Copy the full SHA 168f40eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f50d83 - Browse repository at this point
Copy the full SHA 2f50d83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 380e6ac - Browse repository at this point
Copy the full SHA 380e6acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b59180 - Browse repository at this point
Copy the full SHA 0b59180View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34808d7 - Browse repository at this point
Copy the full SHA 34808d7View commit details -
Allow warnings when validating podspec
Ideally, this should be removed once the warnings have been addressed
Configuration menu - View commit details
-
Copy full SHA for 5baf0b9 - Browse repository at this point
Copy the full SHA 5baf0b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78bd117 - Browse repository at this point
Copy the full SHA 78bd117View commit details -
Configuration menu - View commit details
-
Copy full SHA for e41da8f - Browse repository at this point
Copy the full SHA e41da8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04e4fc8 - Browse repository at this point
Copy the full SHA 04e4fc8View commit details
Commits on Apr 17, 2024
-
Merge remote-tracking branch 'origin/tooling/fix-sync-pod-publication…
…' into mokagio/xcode-15.3
Configuration menu - View commit details
-
Copy full SHA for 210f02c - Browse repository at this point
Copy the full SHA 210f02cView commit details
Commits on Apr 18, 2024
-
Fix NSSecureCoding implementations
@mokagio This should fix the `testPaste{Image,Video}WithoutFormatting` test failures. - I have searched the code for `decodeObject(forKey` occurrences and confirmed there wasn't any left - But I have not triple-checked that *every* custom subclass of anything we might encode in our `NSAttributedString` attributes have had `+supportsSecureCoding` redefined Indeed, apparently, **even if** the parent class already overrides it to return `true`, subclasses which override `init?(coder:)`/`encode(with:)` from their parent class need to also re-override `+supportsSecureCoding`. I've added the overrides in classes that I've modified, but there may be more classes that might not be covered by our unit tests around archiving/pasting but would still require it to be added? So would be worth making another pass to be sure we didn't forget any,
Configuration menu - View commit details
-
Copy full SHA for 665b15b - Browse repository at this point
Copy the full SHA 665b15bView commit details -
Use
UTType.utf8PlainText
(explicit encoding) instead of `kUTTypePla……inText` Since newer versions of iOS use this new `public.utf8-plain-text` UTI instead of `public.plain-text` like in previous OS versions.
Configuration menu - View commit details
-
Copy full SHA for 90c0e4d - Browse repository at this point
Copy the full SHA 90c0e4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c3004b - Browse repository at this point
Copy the full SHA 5c3004bView commit details -
Revert "Fix overriding non-open class outside module"
This reverts commit 5c3004b, because I'm not convinced that's a good idea. We should double-check that **not** having `+supportsSecureCoding` declared on this subclass doesn't make it fail to be copy/pasted (i.e. archived/unarchived)—like similar cases happened when running Aztec tests. Or if we need `+supportsSecureCoding`, we need to find a way to override/redefine it across module boundaries…
Configuration menu - View commit details
-
Copy full SHA for e21dbff - Browse repository at this point
Copy the full SHA e21dbffView commit details -
Configuration menu - View commit details
-
Copy full SHA for c67821c - Browse repository at this point
Copy the full SHA c67821cView commit details
Commits on Apr 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 83e548f - Browse repository at this point
Copy the full SHA 83e548fView commit details
Commits on May 21, 2024
-
Fix shorcode test by using an attribute with key-value
Gerardo committedMay 21, 2024 Configuration menu - View commit details
-
Copy full SHA for ce0726e - Browse repository at this point
Copy the full SHA ce0726eView commit details -
Merge pull request #1395 from wordpress-mobile/fix/shortcode-test
Fix - Shortcode test
Gerardo Pacheco authoredMay 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 7531747 - Browse repository at this point
Copy the full SHA 7531747View commit details