task: Log network activity #238
Open
+1,117
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
the
[Type] Task
Make reading files easier, encountering high-level logic first before the implementation details of helper utilities.
All requests were failing due to the blocking processing of the body.
The data structure for networking logging is incompatible with `dispatchToBridge`.
The absence of these keys resulted in resetting the value to its default when converting the configuration to a builder.
Avoid logging `[Object object]` string values.
Improve assertion explicitness.
dcalhoun
force-pushed
the
feat/log-network-activity
branch
from
aa07850 to
eac9a47
Compare
jkmassel
approved these changes
Nov 27, 2025
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
This works well on iOS – adding @oguzkocer as a reviewer for Android to confirm that all the data is present there.
Contributor
|
@jkmassel I've tested this in WPAndroid Chucker integration and it worked well. The only missing bit was the status text, which is relatively easy to map from the status code, so I think it's fine to land as is. Note that I didn't review the implementation. Let me know if that's needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow logging network activity occurring in the WebView.
Why?
Improve observability and debugging of editor network activity.
How?
window.fetchto intercept network activity.Testing Instructions
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.