-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuntimeException: JSON Parse error: Unexpected end of input #16842
Comments
Definitely, the issue looks related to Reanimated library hence the Gutenberg Mobile side. I did a quick check on the Sentry event and noticed that this crash has more events in version 19.9 than 20.0, however, the adoption for 19.9 is now way lower than 20.0. It's not clear to me the reason for having fewer events on 20.0 because, as far as I checked, we didn't introduce either a dependency update or fix that could have helped reduce the crash 🤔 . In version 20.1, we have introduced an upgrade on Being this said, we should investigate it further in case we can't provide a fix, although I'd like to share that this error is also being reported in the |
This issue might also be related to the following ones: |
cc @geriux in case you could take a look at some point and/or provide further insights, thanks 🙇 ! |
Thank you all for triaging this! 🙇 If I can help in any way, just let me know. |
I'll check it out 👍 |
I was not able to reproduce this. I wondered whether localization could be a factor in this somehow, or characters being improperly handled during parsing, but I did not see a pattern by locale in Sentry 🤷♂️ , so I don't think that is a good hint. One thing that could be a clue is that I did not see any events reported for Android 12, but did see events for Android 11, 10, 9, and 8.1.0. Perhaps something in the library code is using non-backward-compatible APIs without properly conditioning OS version? |
I'm not able to reproduce this. I'm going to close this for now. It can always be opened if there are new instances found. |
## Summary This PR should fix "JSON Parse error: Unexpected end of input" error from Hermes VM happening when `JSON.parse` invoked by `jsi::Value::createFromJsonUtf8` (see [here](https://github.com/facebook/react-native/blob/62fa6d9dac185add0b8998fe1a443beaef3a49bc/ReactCommon/jsi/jsi/jsi.cpp#L139-L144)) fails due to malformed payload. Related issues: * Expensify/App#14878 * wordpress-mobile/WordPress-Android#16842 * #2823 ## Test plan Run Example and FabricExample app on Android.
This PR should fix "JSON Parse error: Unexpected end of input" error from Hermes VM happening when `JSON.parse` invoked by `jsi::Value::createFromJsonUtf8` (see [here](https://github.com/facebook/react-native/blob/62fa6d9dac185add0b8998fe1a443beaef3a49bc/ReactCommon/jsi/jsi/jsi.cpp#L139-L144)) fails due to malformed payload. Related issues: * Expensify/App#14878 * wordpress-mobile/WordPress-Android#16842 * #2823 Run Example and FabricExample app on Android.
## Summary This PR should fix "JSON Parse error: Unexpected end of input" error from Hermes VM happening when `JSON.parse` invoked by `jsi::Value::createFromJsonUtf8` (see [here](https://github.com/facebook/react-native/blob/62fa6d9dac185add0b8998fe1a443beaef3a49bc/ReactCommon/jsi/jsi/jsi.cpp#L139-L144)) fails due to malformed payload. Related issues: * Expensify/App#14878 * wordpress-mobile/WordPress-Android#16842 * software-mansion#2823 ## Test plan Run Example and FabricExample app on Android.
Sentry Url: https://sentry.io/share/issue/b392449ada9e45049409392eb4c502af/
User Count: 164
Count: 428
First Release: 19.9-rc-2
First Seen: 2022-05-22T15:53:57.358000Z
Last Seen: 2022-06-30T09:16:32Z
24 Hours: 22
30 Days: 429
Seems to be related to the reanimated library again (cc @fluiddot ?), yet it's apparently also appearing in
20.1-rc-*
and20.2-rc-1
(while I think we updated the lib recently).PS: Reporting here in WPAndroid repo rather than gutenberg-mobile, because (1) I couldn't find a similar "JSON Parse error" in Sentry for WPiOS and (2) I think the groundskeeper (cc @twstokes) mostly triage issues in WPiOS/WPAndroid but they might not think to look and triage issues in gutenberg-mobile, so decided to report it here for visibility after all. Let me know if you prefer I do otherwise for cases like this in the future.
The text was updated successfully, but these errors were encountered: