-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make remote preview works for drafts on self hosted sites #10322
Make remote preview works for drafts on self hosted sites #10322
Conversation
… comments in the RemotePreviewLogicHelper class.
Generated by 🚫 dangerJS |
…remote-preview-should-work-for-drafts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxme This is looking good. I have one suggestion (⭐️) for your consideration. If you don't agree, feel free to merge.
I'd also like to note that it's possible for a user to turn a published post into a draft when using Preview. Steps:
- Edit a published post
- Go to Post Settings and change the Status to Draft.
- Exit Post Settings and click on Preview.
The post will be uploaded and changed to a draft. I don't think we should fix this right away. I believe we've had a discussion about this UI in one of the Offline Posting tickets. I can't quite remember what our decision for that was.
Luckily, it's not possible to accidentally publish something. 🤷♂
WordPress/src/main/java/org/wordpress/android/ui/posts/RemotePreviewLogicHelper.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/RemotePreviewLogicHelper.kt
Show resolved
Hide resolved
Yes, it's possible to unpublish that way, but that sounds more like a problem with the Post Settings status than related to this change. Also note this is possible on any kind of site (Self hosted, Jetpack or wpcom). Ready for a second pass. |
Thank you, @maxme!
I agree. |
Make remote preview works for drafts on self hosted sites
Fist discussed here: #10212 (comment)
To test:
Case 1:
Case 2:
Update release notes:
RELEASE-NOTES.txt
.