Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make remote preview works for drafts on self hosted sites #10322

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Aug 2, 2019

Make remote preview works for drafts on self hosted sites

Fist discussed here: #10212 (comment)

To test:

Case 1:

  • On a self hosted site (not connected via Jetpack)
  • Open a published post and modify its content
  • Tap the "Preview" button in the overflow menu
  • You should get a "Preview unavailable" screen

Case 2:

  • On a self hosted site (not connected via Jetpack)
  • Create (or edit) a draft
  • Tap the "Preview" button in the overflow menu
  • You should get a the preview screen (after a "Saving" progress popover).

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@maxme maxme requested a review from shiki August 2, 2019 12:20
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 2, 2019

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Copy link
Member

@shiki shiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxme This is looking good. I have one suggestion (⭐️) for your consideration. If you don't agree, feel free to merge.

I'd also like to note that it's possible for a user to turn a published post into a draft when using Preview. Steps:

  1. Edit a published post
  2. Go to Post Settings and change the Status to Draft.
  3. Exit Post Settings and click on Preview.

The post will be uploaded and changed to a draft. I don't think we should fix this right away. I believe we've had a discussion about this UI in one of the Offline Posting tickets. I can't quite remember what our decision for that was.

Luckily, it's not possible to accidentally publish something. 🤷‍♂

@maxme
Copy link
Contributor Author

maxme commented Aug 6, 2019

I'd also like to note that it's possible for a user to turn a published post into a draft when using Preview. Steps:

1. Edit a published post
2. Go to Post Settings and change the Status to Draft.
3. Exit Post Settings and click on Preview.

Yes, it's possible to unpublish that way, but that sounds more like a problem with the Post Settings status than related to this change. Also note this is possible on any kind of site (Self hosted, Jetpack or wpcom).

Ready for a second pass.

@shiki
Copy link
Member

shiki commented Aug 6, 2019

Thank you, @maxme!

but that sounds more like a problem with the Post Settings status than related to this change.

I agree.

@shiki shiki merged commit 6a3a0e9 into feature/master-remote-previews Aug 6, 2019
@shiki shiki deleted the issue/self-hosted-remote-preview-should-work-for-drafts branch August 6, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants