Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support multiple prop in gutenberg editor #10556

Merged
merged 18 commits into from
Oct 2, 2019
Merged

feat: support multiple prop in gutenberg editor #10556

merged 18 commits into from
Oct 2, 2019

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Oct 2, 2019 •
edited
Loading

Callstack PR #10475:

Text below is copied from the related Callstack PR:

In this PR I added the possibility to set multiple media when inserting to the block.
Related gutenberg-mobile PR wordpress-mobile/gutenberg-mobile#1331
To test:
At this moment we don't support gallery block so this change can not be tested without changes in gutenberg-mobile JS bundle. In the future, we will use this functionality to multiple selections of media for the gallery.

  • set multiple prop to true in media-upload bloc
  • add image/video block - multiple select should be enabled for selecting media from the device or WP Media
  • the array of selected media should be passed to the callback function

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 2, 2019 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

This was referenced Oct 2, 2019
Merged
Merged
@mkevins mkevins requested review from maxme and pinarol October 2, 2019 13:45
pinarol
pinarol approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@pinarol pinarol merged commit b93cf48 into develop Oct 2, 2019
@pinarol pinarol deleted the callstack/multiple-select branch October 2, 2019 13:53
pinarol added a commit that referenced this pull request Oct 2, 2019
@pinarol
Revert "Merge pull request #10556 from wordpress-mobile/callstack/mul…
4540c6b 
…tiple-select"

This reverts commit b93cf48, reversing
changes made to 569e1b2.
@pinarol pinarol mentioned this pull request Oct 2, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@maxme maxme Awaiting requested review from maxme

Assignees
No one assigned
Labels
Media
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkevins @pinarol @dratwas