Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gutenberg-mobile release 1.46.1 to 1.47.0 #14092

Merged
merged 34 commits into from
Feb 18, 2021
Merged

Integrate gutenberg-mobile release 1.46.1 to 1.47.0 #14092

merged 34 commits into from
Feb 18, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Feb 17, 2021 •
edited
Loading

This PR incorporates the changes from 1.46.1 release of gutenberg-mobile to 1.47.0 release.

It also incorporates a couple of fixes that were merged into the release/16.7 branch:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

ceyhun and others added 30 commits February 11, 2021 16:34
@ceyhun
Update gutenberg-mobile ref
ab219a8
@jd-alexander
Only enable the audio block on premium plans.
b0cbc59
@jd-alexander
Sync enable/disable audio block logic with iOS. Made it clearer.
1b10934
@develric
Using clear instead of setting text to empty string
7f77753
@develric
Adding textEmailAddress to EditText inputType
69224d1
@planarvoid
Merge pull request #14063 from wordpress-mobile/fix/keyboard-creates-…
f6cca03 
…chips-on-dot

With some keyboard creates chips on dot
@fluiddot
Release script: Update gutenberg-mobile ref
2d75ab9
@jd-alexander
Updated gutenberg-mobile ref.
15668d1
@jd-alexander
updated commit to the merge hash.
a86f319
@jd-alexander
Merge branch 'gutenberg/integrate_release_1.46.1' into feature/show-h…
b253761 
…ide-audio-block
@jd-alexander
Merge pull request #14037 from wordpress-mobile/feature/show-hide-aud…
c018009 
…io-block

[Gutenberg] Hide audio block on free sites
@ashiagr
Fix crash on snackbar display
134bab0
@ashiagr
Fix ktlint
12f2fda
@AliSoftware @ashiagr
Invalidate bundler cache to fix CI failure
721e47b
@fluiddot
Update gutenberg-mobile ref
e9b024b
@fluiddot
Update gutenberg-mobile ref and release notes
213b482
@AliSoftware
Attempt to fix the CI bundler/rake cache failure again
59a710f
@AliSoftware
bundle update, to rebuild the Gemfile snapshot
c9ec2d5
@AliSoftware
Invalidate checksum-less cache key again
13f2064
@AliSoftware
Update to bundler 2.2.10 (security fix) and bundle update google-clou…
82f610a 
…d-storage to fix resolution
@fluiddot
Revert "Update release notes"
ff96cff
@AliSoftware @fluiddot
Attempt to fix the CI bundler/rake cache failure again
25c6748 
# Conflicts:
#	.circleci/config.yml
@AliSoftware @fluiddot
bundle update, to rebuild the Gemfile snapshot
e0ad5ea
@AliSoftware @fluiddot
Invalidate checksum-less cache key again
5d85a1e
@AliSoftware @fluiddot
Update to bundler 2.2.10 (security fix) and bundle update google-clou…
d27f78b 
…d-storage to fix resolution
@AliSoftware @fluiddot
Stop using multi-source mode - so that the release-toolkit gem also u…
dfcb92c 
…se the rubygems.org source
@malinajirka
Merge pull request #14078 from wordpress-mobile/issue/fix-snackbar-crash
40a3c4a 
Jetpack Section: Scan - fix crash on snackbar display
@jkmassel
Update Bundler + Fix Gemfile
84807ac
@jkmassel
Merge pull request #14086 from wordpress-mobile/fix/gemfile-in-16.7-r…
735f000 
…elease-branch

Fix gemfile in 16.7 release branch
@fluiddot
Update gutenberg-mobile ref
53672c0
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 17, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 17, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

fluiddot and others added 3 commits February 17, 2021 13:24
@dcalhoun dcalhoun mentioned this pull request Feb 17, 2021
Merged
3 tasks
@fluiddot fluiddot marked this pull request as ready for review February 18, 2021 08:20
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

antonis
antonis approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@antonis antonis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @fluiddot 👍
I did a quick walkthrough on the generated build and everything looked good (test device Pixel 2 XL / Android 11). Also validated the introduced fixes.
The code changes are consistent and LGTM 🎉

@fluiddot fluiddot merged commit b399a55 into gutenberg/integrate_release_1.47.0 Feb 18, 2021
@fluiddot fluiddot deleted the gutenberg/integrate_release_1.46.1_to_1.47.0 branch February 18, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@ceyhun ceyhun Awaiting requested review from ceyhun

@dcalhoun dcalhoun Awaiting requested review from dcalhoun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.