-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Update code comment for clarity #16547
Merged
hypest
merged 5 commits into
trunk
from
gutenberg/chore/update-xpost-comment-for-clarification
May 16, 2022
Merged
[RNMobile] Update code comment for clarity #16547
hypest
merged 5 commits into
trunk
from
gutenberg/chore/update-xpost-comment-for-clarification
May 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
SiobhyB
added
Gutenberg
Editing and display of Gutenberg blocks.
gutenberg-mobile
labels
May 13, 2022
SiobhyB
changed the title
[RNMobile] Update comment for clarity
[RNMobile] Update code comment for clarity
May 13, 2022
3 tasks
You can test the changes on this Pull Request by downloading the APKs: |
hypest
reviewed
May 13, 2022
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
"If the site is using the WP.com API..." was too verbose, especially considering that was evident from reading the conditional itself. It's therefore been removed with this comment. Instead, the previous sentence will be iterated on in a following commit to clarify why the 'isUsingWpComRestApi' is used.
This reverts commit 30ecde5.
"If the site is using the WP.com API..." was too verbose, especially considering that was evident from reading the conditional itself. It's therefore been removed with this comment. Instead, the previous sentence will be iterated on in a following commit to clarify why the 'isUsingWpComRestApi' is used.
Co-authored-by: Stefanos Togoulidis <stefanostogoulidis@gmail.com>
hypest
approved these changes
May 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback received at #16507 (comment)
In #16507, a conditional that communicates whether xPosts are enabled on a site was updated to check whether a site was hosted on WordPress.com. The reason for this change is that the conditional's
mIsXPostsCapable
boolean returnstrue
for .org sites by default. As the app only support xPosts for WordPress.com sites using a P2-based theme, an unresponsive+
icon was being displayed in the editor's toolbar for .org sites.The updated conditional, including comment, was as follows:
This feedback suggested that the comment could be updated for clarity, given the change. As such, this PR proposes the following change:
Regression Notes
As this is a change to a code comment, no user-facing regressions are predicted. The only negative, unintentional impact would be developer confusion, if the comment isn't clear.
N/A
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.