-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React Native Reanimated to 2.9.1-wp-3
#17846
Conversation
📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17846-ae5ec93.apk
|
📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17846-ae5ec93.apk
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installed the build from this PR and confirmed that the editor loads without crashing, and I couldn't spot any obvious issues with some light manual testing.
Approving, given the CI checks also pass and all looks good with the general changes in the Gutenberg PR.
Thanks for working on this, Gerardo! 🎉 🚀
Generated by 🚫 dangerJS |
# Conflicts: # build.gradle
Found 1 violations: The PR caused the following dependency changes: \--- project :libs:editor
- \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.87.3
- +--- com.facebook.fresco:animated-gif:2.0.0
- | +--- com.parse.bolts:bolts-tasks:1.4.0
- | +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
- | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | \--- com.facebook.fresco:animated-base:2.0.0
- | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
- | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
- | +--- com.facebook.fresco:animated-drawable:2.0.0
- | | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
- | | +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
- | | \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | \--- com.parse.bolts:bolts-tasks:1.4.0
- +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
- +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
- | +--- com.google.android.exoplayer:exoplayer:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3
- | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | | \--- com.google.guava:guava:27.1-android
- | | | | +--- com.google.guava:failureaccess:1.0.1
- | | | | \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
- | | | \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
- | | +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
- | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
- | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | +--- androidx.recyclerview:recyclerview:1.1.0 (*)
- | | \--- androidx.media:media:1.2.1 (*)
- | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
- | +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
- | +--- com.google.android.exoplayer:extension-okhttp:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
- | \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
- +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
- +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
- +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-2
- +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
- +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
- | +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-2
- | +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
- | +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
- | +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
- | +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
- | +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
- | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
- | \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
- | +--- com.github.bumptech.glide:glide:4.12.0
- | | +--- com.github.bumptech.glide:gifdecoder:4.12.0
- | | | \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
- | | +--- com.github.bumptech.glide:disklrucache:4.12.0
- | | +--- com.github.bumptech.glide:annotations:4.12.0
- | | +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
- | | +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
- | | \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
- | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
- | +--- com.github.bumptech.glide:glide:4.12.0 (*)
- | +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
- | \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
- +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.87.3
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | +--- androidx.gridlayout:gridlayout:1.0.0
- | | +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
- | | \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
- | +--- androidx.cardview:cardview:1.0.0 (*)
- | +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
- | +--- androidx.recyclerview:recyclerview:1.1.0 (*)
- | +--- org.wordpress:aztec:v1.6.2 (*)
- | +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.2 (*)
- | +--- org.wordpress.aztec:wordpress-comments:v1.6.2 (*)
- | +--- org.wordpress.aztec:glide-loader:v1.6.2
- | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.21 (*)
- | | +--- org.wordpress:aztec:v1.6.2 (*)
- | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+ \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.88.0-alpha1
+ +--- com.facebook.fresco:animated-gif:2.0.0
+ | +--- com.parse.bolts:bolts-tasks:1.4.0
+ | +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+ | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | \--- com.facebook.fresco:animated-base:2.0.0
+ | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+ | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+ | +--- com.facebook.fresco:animated-drawable:2.0.0
+ | | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+ | | +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+ | | \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | \--- com.parse.bolts:bolts-tasks:1.4.0
+ +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+ +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
+ | +--- com.google.android.exoplayer:exoplayer:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+ | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | | \--- com.google.guava:guava:27.1-android
+ | | | | +--- com.google.guava:failureaccess:1.0.1
+ | | | | \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+ | | | \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+ | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+ | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+ | | \--- androidx.media:media:1.2.1 (*)
+ | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
+ | +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+ | +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+ | \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+ +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
+ +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
+ +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
+ +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
+ +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
+ | +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
+ | +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+ | +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
+ | +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
+ | +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
+ | +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+ | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+ | \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
+ | +--- com.github.bumptech.glide:glide:4.12.0
+ | | +--- com.github.bumptech.glide:gifdecoder:4.12.0
+ | | | \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+ | | +--- com.github.bumptech.glide:disklrucache:4.12.0
+ | | +--- com.github.bumptech.glide:annotations:4.12.0
+ | | +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+ | | +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+ | | \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
+ | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+ | +--- com.github.bumptech.glide:glide:4.12.0 (*)
+ | +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
+ | \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+ +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.88.0-alpha1
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | +--- androidx.gridlayout:gridlayout:1.0.0
+ | | +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+ | | \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+ | +--- androidx.cardview:cardview:1.0.0 (*)
+ | +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+ | +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+ | +--- org.wordpress:aztec:v1.6.3 -> v1.6.2 (*)
+ | +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 -> v1.6.2 (*)
+ | +--- org.wordpress.aztec:wordpress-comments:v1.6.3 -> v1.6.2 (*)
+ | +--- org.wordpress.aztec:glide-loader:v1.6.3
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+ | | +--- org.wordpress:aztec:v1.6.3 -> v1.6.2 (*)
+ | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
Please review and act accordingly
|
I'm closing this PR because the Gutenberg Mobile reference update included in this PR was superseded by #17852. |
Related PR:
2.9.1-wp-3
gutenberg-mobile#5430To test check the CI checks succeed and the editor opens correctly.
Regression Notes
Potential unintended areas of impact
Editor
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and CI checks
What automated tests I added (or what prevented me from doing so)
None
PR submission checklist:
RELEASE-NOTES.txt
if necessary.