Refactor: Replace mutex.lock() with mutex.withLock()

[zwarm]

Parent #17463
(CompletionHandlerException: Exception in resume onCancellation handler for CancellableContinuation(DispatchedContinuation[Dis...)

The goal of this PR is to try and fix the IllegalStateException: Mutex is not locked issue that occurs when uploading local changes.

The intent is to change from using mutex.lock() to mutex.withLocking(). This should ensure that we have access to the locked mutex before trying to unlock it. The theory behind this is that we may be experiencing a race condition since mutex.isLocked() only gives us the "at this moment" answer, another process could have come in before we get to the unlock.

Using withLock should automatically manage the locking/unlocking of the mutex, and in addition, we can call mutex.unlock() when we experience a CancellationException without needing to check the isLocked beforehand.

If anyone thinks this is a bad idea, we can nix it. Figured it was worth a try. :)

To test:
There is nothing specific to test; as we haven't been able to reproduce this crash.
Please take the apps out for a generic spin - create/update some posts, turn networking on/off, etc.

Regression Notes

1. Potential unintended areas of impact
   N/A

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N/A

3. What automated tests I added (or what prevented me from doing so)
   N/A

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr18067-1b5e1f3.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	Jetpack
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	1b5e1f3

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[wpmobilebot]

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr18067-1b5e1f3.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	WordPress
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	1b5e1f3

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[peril-wordpress-mobile]

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

[zwarm]

Note: Moved to a draft PR. Although all the current tests pass, there is still some uncertainty as to whether this will make a difference.

[ovitrif]

Note: Moved to a draft PR. Although all the current tests pass, there is still some uncertainty as to whether this will make a difference.

I think these days "I feel in better shape" to retry simulating this error via TDD. Will try to find some time this week or next week to dedicate to this 🙇🏻

Thanks for drafting this PR @zwarm !

[ovitrif]

@zwarm Let's try this out, it can't hurt 👍🏻

Plus, GPT subscribes:

[ovitrif]

LGTM

IMHO it can't hurt to try this out, we'll keep monitoring the crash frequency and see if it actually does fix the issue.