-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependency Updates] Update androidVolleyVersion
to 1.2.1
#18125
Conversation
Found 1 violations: The PR caused the following dependency changes: +--- project :libs:editor
-| \--- com.android.volley:volley:1.1.1 -> 1.2.0
+| \--- com.android.volley:volley:1.2.1
+--- org.wordpress:fluxc:{strictly 2.17.0} -> 2.17.0
-| \--- com.android.volley:volley:1.1.1 -> 1.2.0
+| \--- com.android.volley:volley:1.1.1 -> 1.2.1
+--- org.wordpress:utils:{strictly 3.3.0} -> 3.3.0
-| \--- com.android.volley:volley:1.2.0
+| \--- com.android.volley:volley:1.2.0 -> 1.2.1
-\--- com.android.volley:volley:1.1.1 -> 1.2.0
+\--- com.android.volley:volley:1.2.1
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi @ParaskP7
All is looking good here. I took the builds out for a spin. I created posts/pages with and without media. I did scheduled posts, drafts, deleted, etc. I ventured into the media area and uploaded videos, pictures from device, used pre-stock images, etc. I went through the reader functions, notifications, comments, app settings, site settings, activity log, stats, and a whole bunch more.
I suspect that if things weren't working as expected they would have showed up. Of course, Murphy's law is a you-know-what, so I am keeping 🤞. I am going to merge. The more eyes on this via trunk will provide the extra verification before it goes to Beta.
Thanks for spearheading the effort!!
Awesome, thank you so much for reviewing, testing and merging this @zwarm , you rock! 🙇 ❤️ 🚀 |
Parent #17568
This PR updates
androidVolleyVersion
to 1.2.1.PS: @zwarm I added you as the main reviewer, randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
To test:
FYI: I didn't add any explicit test steps to accommodate this update as
Volley
and theNetworking
module is being utilized in lots of places (expand classes per module list below). Thus, it is better to just test the app as a whole, by trying to test as many screens and functionalities as possible, and make sure that everything is working as expected.PS: Having said the above, in that classes per module list below, I did provide most of the main classes that
Volley
and theNetworking
module is being used in order to make it easier for you to target specific screen and functionality while testing, like thePost
,Reader
andNotifications
screens and its corresponding functionalities.1. Networking Module
RestClientFactory
AuthenticatorRequest
RestClientUtils
2. Editor Module
AztecEditorFragment
GutenbergEditorFragment
ImageSettingsDialogFragment
3. WordPress Module
AppInitializer
+BitmapLruCache
WordPress
+LegacyModule
VolleyUtils
+PeopleUtils
+ReaderVideoUtils
+NotificationsUtils
WPComSiteSettings
+SiteSettingsTimezoneViewModel
+NotificationsSettingsFragment
RecommendApiCallsProvider
+InviteLinksApiCallsProvider
+PostSeenStatusApiCallsProvider
+PostSubscribersApiCallsProvider
ReaderCommentService
+ReaderDiscoverLogic
+ReaderPostLogic
+ReaderSearchLogic
+ReaderUpdateLogic
+ReaderBlogActions
+ReaderCommentActions
+ReaderPostActions
+ReaderTagActions
NotificationsProcessingService
+NotificationsUpdateLogic
+NotificationsActions
+NotificationEvents
SuggestionService
+ServerTrackingHandler
PublicizeUpdateService
+PublicizeActions
SitePickerActivity
ReactNativeRequestHandler
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To test
section above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.