Add Gutenberg Embed WebView Activity #18383

jhnstn · 2023-05-08T15:20:04Z

Fixes wordpress-mobile/gutenberg-mobile#5509

Adds a new embed WebView for the editor.

Related PRs:

To test:

Apply both related PRs.
Open a post with a VideoPress block in the Editor
Select the VideoPress block and press again to play the preview video
The VideoPress embed player should open in a WebView
Exit the WebView via swipe or by pressing the back arrow.
Expect to return to the editor.

Regression Notes

Potential unintended areas of impact
Gutenberg bridge code - minimal.
What I did to test those areas of impact (or what existing automated tests I relied on)
Existing code was not altered for these changes.
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

wpmobilebot · 2023-05-09T03:06:17Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18383-144b55d
	Commit	`144b55d`
	Direct Download	`jetpack-prototype-build-pr18383-144b55d.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-05-09T03:07:14Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18383-144b55d
	Commit	`144b55d`
	Direct Download	`wordpress-prototype-build-pr18383-144b55d.apk`

Note: Google Login is not supported on these builds.

fluiddot

@jhnstn I tested the changes and work as expected. I added a couple of comments that shouldn't block the PR, let me know if you could take a look.

libs/editor/src/main/java/org/wordpress/android/editor/WPGutenbergEmbedWebViewActivity.java

libs/editor/src/main/AndroidManifest.xml

fluiddot · 2023-05-10T09:36:29Z

@jhnstn since this PR also enables the VideoPress block on Android, what do you think about updating the PR's title and description to reflect this?

UPDATE: Alternatively, we could enable the block in a separate PR.

fluiddot

I tested the last installable build and noticed the following issues:

R-rated videos

The keyboard remains open when introducing the DOB and closing the WebView. We'd need to figure out how to force closing the keyboard when going back from the WebView.

NOTE: I saw that we have a similar issue when interacting with the prompt dialog.

android-videopress-dob.mp4

Additionally, I noticed that R-rated videos display the DOB prompt in the editor. Since the player will be only available via the WebView, I'm wondering if instead of rendering the preview content, we could simply display the poster image with a play button. I wouldn't consider this a blocker but more like an enhancement.

Private videos

I checked that private videos are not displayed when opening a WebView, this issue is a bit critical as the player is not available. Hence, I'd consider it a blocker for releasing the block on Android.

In theory, the VideoPress URL set in the iframe's source should contain the token (reference), so not sure why private videos can't be played 🤔.

android-videopress-private-videos.mp4

jhnstn · 2023-05-10T15:41:47Z

Thanks for finding these @fluiddot

Can you give any more info on the private video case? I've testing with private videos but can't reproduce:

screen-20230510-110542.mp4

That's on a simple site where videos are not private by default but that particular video is set as private. I've also tried with the site set to private. The player loads for me in both cases.

Regarding the mature settings, I expect being able to force close the keyboard should be possible when the WebView is closed. My feeling is that is not a blocker to this PR but also borderline as a blocker to releasing VP on Android.

fluiddot · 2023-05-10T16:02:12Z

Can you give any more info on the private video case? I've testing with private videos but can't reproduce:

@jhnstn Yep, sorry I didn't share all the info. I reproduced it using a Premium simple site with site privacy set to Private. I can also reproduce it by setting the site Public. I tested using the installable build pr18383-144b55d. In the video you shared, I noticed that it's in development mode by the RN error/warning messages. Can you try to reproduce it using the installable build?

Tested with Samsung Galaxy S20 FE 5G (Android 13).

Regarding the mature settings, I expect being able to force close the keyboard should be possible when the WebView is closed. My feeling is that is not a blocker to this PR but also borderline as a blocker to releasing VP on Android.

I agree, I wouldn't consider it a blocker for the PR but a nice-to-have before releasing on Android.

fluiddot

@jhnstn Yep, sorry I didn't share all the info. I reproduced it using a Premium simple site with site privacy set to Private. I can also reproduce it by setting the site Public. I tested using the installable build pr18383-144b55d. In the video you shared, I noticed that it's in development mode by the RN error/warning messages. Can you try to reproduce it using the installable build?

I'm testing again and, after uploading a video and marking it as private, now I can't reproduce the issue 🙃. However, for the video I shared in the video captured above, I'm still not able to play it. For some reason, I'm having weird connection issues in the Android device I'm using, so I'm suspecting that might be related to that. That said, now that I can't reproduce it I'll approve the PR.

LGTM 🎊 !

lmischner · 2023-05-10T16:28:00Z

Talkback doesn't seem to work very well with the web view.
With Talkback on, when I open the web view, focus is on the close button (which seems fine), but, after reading the video file name, talkback says "play video, share button, doubletap activate'. This isn't accurate -- double tapping closes the video.
If I tap on the video itself, Talkback doesn't read anything so a low sighted user wouldn't know there's a video to play or how to do so.

jhnstn · 2023-05-10T17:42:03Z

@lmischner I'm not sure we can do much about these talkback issues. The only think we control in the WebView is the iframe. The player itself loads from VideoPress.
We can use JavaScript to listen for play/pause events from the player but I'm not sure how we can feed those into the Android talkback system. I'm looking into that now.

wpmobilebot · 2023-05-10T19:47:59Z

Found 1 violations:

The PR caused the following dependency changes:

 \--- project :libs:editor
-     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.94.0
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
-          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
-          +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
-          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
-          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
-          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
-          |    +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
-          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
-          |    +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
-          |    +--- com.github.bumptech.glide:glide:4.12.0
-          |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
-          |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-          |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
-          |    |    +--- com.github.bumptech.glide:annotations:4.12.0
-          |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
-          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
-          |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
-          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-          |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
-          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
-          |         \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.94.0
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0
-          |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
-          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
-          |    +--- org.wordpress:aztec:v1.6.3 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v1.6.3
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
-          |    |    +--- org.wordpress:aztec:v1.6.3 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
-          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.95.0-alpha1
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
+          +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
+          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
+          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
+          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
+          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+          |    +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
+          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
+          |    +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
+          |    +--- com.github.bumptech.glide:glide:4.12.0
+          |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
+          |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+          |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
+          |    |    +--- com.github.bumptech.glide:annotations:4.12.0
+          |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+          |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
+          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+          |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
+          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
+          |         \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.95.0-alpha1
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0
+          |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+          |    +--- org.wordpress:aztec:v1.6.3 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v1.6.3
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+          |    |    +--- org.wordpress:aztec:v1.6.3 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)

Please review and act accordingly

jhnstn added 3 commits May 5, 2023 21:55

Add Gutenberg Embed WebView Activity

6cf4b08

Remove debugging setup

0946021

Linting

98e070a

This was referenced May 8, 2023

[RNMobile] Add embed webview for Android WordPress/gutenberg#50440

Merged

[RNMobile] VideoPress Android WebView Automattic/jetpack#30521

Merged

Add embed webview wordpress-mobile/gutenberg-mobile#5743

Merged

jhnstn added 3 commits May 8, 2023 16:21

Update Gutenberg ref

1113dc2

Update Gutenberg ref

5807107

Update Gutenberg

6bb6eb2

jhnstn requested review from fluiddot and SiobhyB May 9, 2023 03:17

jhnstn marked this pull request as ready for review May 9, 2023 03:17

jhnstn added 2 commits May 8, 2023 23:27

Update Gutenberg

662b5d2

Trigger CI

d9ad6ca

fluiddot reviewed May 9, 2023

View reviewed changes

libs/editor/src/main/java/org/wordpress/android/editor/WPGutenbergEmbedWebViewActivity.java Outdated Show resolved Hide resolved

libs/editor/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

Remove class WPGutenbergEmbedWebViewActivity

9ffa9f0

jhnstn requested a review from fluiddot May 9, 2023 17:55

jhnstn added 2 commits May 9, 2023 14:33

Update Gutenberg

32e2752

Trigger CI

144b55d

fluiddot added this to the 22.4 milestone May 10, 2023

fluiddot added the gutenberg-mobile label May 10, 2023

fluiddot reviewed May 10, 2023

View reviewed changes

jhnstn requested a review from fluiddot May 10, 2023 15:55

fluiddot approved these changes May 10, 2023

View reviewed changes

jhnstn added 3 commits May 10, 2023 14:38

Point Gutenberg to v1.95.0-alpha1

601d7f0

Trigger CI

fc222e3

fix typo in gb source

d790b45

jhnstn enabled auto-merge May 10, 2023 19:54

jhnstn disabled auto-merge May 10, 2023 19:55

jhnstn enabled auto-merge (squash) May 10, 2023 19:55

jhnstn merged commit f7cbb06 into trunk May 10, 2023

jhnstn deleted the add/gutenberg-embed-webview branch May 10, 2023 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Gutenberg Embed WebView Activity #18383

Add Gutenberg Embed WebView Activity #18383

jhnstn commented May 8, 2023 •

edited

Loading

wpmobilebot commented May 9, 2023 •

edited

Loading

wpmobilebot commented May 9, 2023 •

edited

Loading

fluiddot left a comment

fluiddot commented May 10, 2023 •

edited

Loading

fluiddot left a comment

jhnstn commented May 10, 2023

fluiddot commented May 10, 2023 •

edited

Loading

fluiddot left a comment

lmischner commented May 10, 2023

jhnstn commented May 10, 2023

wpmobilebot commented May 10, 2023

Add Gutenberg Embed WebView Activity #18383

Add Gutenberg Embed WebView Activity #18383

Conversation

jhnstn commented May 8, 2023 • edited Loading

Regression Notes

wpmobilebot commented May 9, 2023 • edited Loading

wpmobilebot commented May 9, 2023 • edited Loading

fluiddot left a comment

Choose a reason for hiding this comment

fluiddot commented May 10, 2023 • edited Loading

fluiddot left a comment

Choose a reason for hiding this comment

R-rated videos

Private videos

jhnstn commented May 10, 2023

fluiddot commented May 10, 2023 • edited Loading

fluiddot left a comment

Choose a reason for hiding this comment

lmischner commented May 10, 2023

jhnstn commented May 10, 2023

wpmobilebot commented May 10, 2023

The PR caused the following dependency changes:

jhnstn commented May 8, 2023 •

edited

Loading

wpmobilebot commented May 9, 2023 •

edited

Loading

wpmobilebot commented May 9, 2023 •

edited

Loading

fluiddot commented May 10, 2023 •

edited

Loading

fluiddot commented May 10, 2023 •

edited

Loading