-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Upgrade Android 13 #18477
Conversation
1362191
to
66e2737
Compare
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
3b85dda
to
000a95c
Compare
Hey @fluiddot 👋 is the editor opening for you with this build? I'm getting a red screen 🤔 |
So far I only tested using a local build and worked without issues. But yes, I'm also getting a red screen with the installable build 😞 , I'll take a look. UPDATE: I managed to reproduce it locally when not pointing to the local Gutenberg Mobile project. |
All React Native dependencies have been updated in the Gutenberg Mobile project. With this, I've tested locally generating the release version of the React Native bundle and using it in the app. So far, I haven't encountered any error/crash like the one we experienced in the installable build. Hence, I've updated the Gutenberg Mobile reference to generate a new build as a final test 🤞 . |
I've tested with a recent build ( |
I've set this PR ready to review but I'd like to note that I'm planning to update it once this change related to a dependency is incorporated in Gutenberg. In any case, I don't expect this change to affect the editor, so we can at least smoke-test it in the meantime. |
5b18aa7
to
665e63e
Compare
@geriux All changes applied, the PR is again ready for review. Let me know if you could take a look, thanks 🙇 ! |
🟢 Writing Flow TestsBuild: jetpack-prototype-build-pr18477-665e63e.apk
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases |
🟢 Writing Flow TestsBuild: jetpack-prototype-build-pr18477-665e63e.apk
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing that testing was done already using two different devices I'll just approve the PR 🚀 Thanks for testing and making these changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing that testing was done already using two different devices I'll just approve the PR 🚀 Thanks for testing and making these changes!
Found 1 violations: The PR caused the following dependency changes: \--- project :libs:editor
- +--- org.wordpress:aztec:{strictly v1.6.3} -> v1.6.3
+ +--- org.wordpress:aztec:{strictly v1.6.4} -> v1.6.4
- +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.6.3} -> v1.6.3
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
- | +--- org.wordpress:aztec:v1.6.3 (*)
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.6.4} -> v1.6.4
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
+ | +--- org.wordpress:aztec:v1.6.4 (*)
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
- +--- org.wordpress.aztec:wordpress-comments:{strictly v1.6.3} -> v1.6.3
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
- | +--- org.wordpress:aztec:v1.6.3 (*)
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+ +--- org.wordpress.aztec:wordpress-comments:{strictly v1.6.4} -> v1.6.4
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
+ | +--- org.wordpress:aztec:v1.6.4 (*)
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
- \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.96.0
- +--- com.facebook.fresco:animated-gif:2.0.0
- | +--- com.parse.bolts:bolts-tasks:1.4.0
- | +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
- | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | \--- com.facebook.fresco:animated-base:2.0.0
- | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
- | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
- | +--- com.facebook.fresco:animated-drawable:2.0.0
- | | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
- | | +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
- | | \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | \--- com.parse.bolts:bolts-tasks:1.4.0
- +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
- +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
- | +--- com.google.android.exoplayer:exoplayer:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3
- | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | | \--- com.google.guava:guava:27.1-android
- | | | | +--- com.google.guava:failureaccess:1.0.1
- | | | | \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
- | | | \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
- | | +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
- | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
- | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
- | | \--- androidx.media:media:1.2.1 (*)
- | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
- | +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
- | +--- com.google.android.exoplayer:extension-okhttp:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.10.0 (*)
- | \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.10.0 (*)
- +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
- +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
- +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
- +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
- +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
- | +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
- | +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
- | +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.8.21 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
- | +--- androidx.appcompat:appcompat:1.1.0 -> 1.6.1 (*)
- | +--- androidx.fragment:fragment:1.2.1 -> 1.5.7 (*)
- | +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
- | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
- | \--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.8.21 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
- | +--- com.github.bumptech.glide:glide:4.12.0
- | | +--- com.github.bumptech.glide:gifdecoder:4.12.0
- | | | \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
- | | +--- com.github.bumptech.glide:disklrucache:4.12.0
- | | +--- com.github.bumptech.glide:annotations:4.12.0
- | | +--- androidx.fragment:fragment:1.0.0 -> 1.5.7 (*)
- | | +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
- | | \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.6 (*)
- | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
- | +--- com.github.bumptech.glide:glide:4.12.0 (*)
- | +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.10.0 (*)
- | \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
- +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.96.0
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | +--- androidx.gridlayout:gridlayout:1.0.0
- | | +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
- | | \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
- | +--- androidx.cardview:cardview:1.0.0 (*)
- | +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
- | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
- | +--- org.wordpress:aztec:v1.6.3 (*)
- | +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
- | +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
- | +--- org.wordpress.aztec:glide-loader:v1.6.3
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
- | | +--- org.wordpress:aztec:v1.6.3 (*)
- | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.8.21 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.8.21 (*)
+ \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.97.0-alpha1
+ +--- com.facebook.fresco:animated-gif:2.0.0
+ | +--- com.parse.bolts:bolts-tasks:1.4.0
+ | +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+ | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | \--- com.facebook.fresco:animated-base:2.0.0
+ | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+ | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+ | +--- com.facebook.fresco:animated-drawable:2.0.0
+ | | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+ | | +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+ | | \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | \--- com.parse.bolts:bolts-tasks:1.4.0
+ +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+ +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
+ | +--- com.google.android.exoplayer:exoplayer:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+ | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | | \--- com.google.guava:guava:27.1-android
+ | | | | +--- com.google.guava:failureaccess:1.0.1
+ | | | | \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+ | | | \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+ | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+ | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+ | | \--- androidx.media:media:1.2.1 (*)
+ | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+ | +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+ | +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.10.0 (*)
+ | \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.10.0 (*)
+ +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-4
+ +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
+ +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-4
+ +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-4
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+ +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-3
+ | +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-4
+ | +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
+ | +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.8.21 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v2:react-native-get-random-values:1.4.0
+ +--- org.wordpress-mobile.react-native-libraries.v2:react-native-safe-area-context:3.2.0
+ +--- org.wordpress-mobile.react-native-libraries.v2:react-native-screens:2.9.0
+ | +--- androidx.appcompat:appcompat:1.1.0 -> 1.6.1 (*)
+ | +--- androidx.fragment:fragment:1.2.1 -> 1.5.7 (*)
+ | +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+ | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+ | \--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v2:react-native-svg:9.13.6
+ +--- org.wordpress-mobile.react-native-libraries.v2:react-native-webview:11.26.1
+ | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.21 (*)
+ | \--- androidx.webkit:webkit:1.4.0
+ | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | \--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v2:react-native-masked-view:0.2.6
+ +--- org.wordpress-mobile.react-native-libraries.v2:react-native-clipboard:1.9.0
+ +--- org.wordpress-mobile.react-native-libraries.v2:react-native-fast-image:8.5.11
+ | +--- com.github.bumptech.glide:glide:4.12.0
+ | | +--- com.github.bumptech.glide:gifdecoder:4.12.0
+ | | | \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+ | | +--- com.github.bumptech.glide:disklrucache:4.12.0
+ | | +--- com.github.bumptech.glide:annotations:4.12.0
+ | | +--- androidx.fragment:fragment:1.0.0 -> 1.5.7 (*)
+ | | +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+ | | \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.6 (*)
+ | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+ | +--- com.github.bumptech.glide:glide:4.12.0 (*)
+ | +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.10.0 (*)
+ | \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+ +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.97.0-alpha1
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | +--- androidx.gridlayout:gridlayout:1.0.0
+ | | +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
+ | | \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+ | +--- androidx.cardview:cardview:1.0.0 (*)
+ | +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
+ | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+ | +--- org.wordpress:aztec:v1.6.4 (*)
+ | +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.4 (*)
+ | +--- org.wordpress.aztec:wordpress-comments:v1.6.4 (*)
+ | +--- org.wordpress.aztec:glide-loader:v1.6.4
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
+ | | +--- org.wordpress:aztec:v1.6.4 (*)
+ | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
Please review and act accordingly
|
Closes wordpress-mobile/gutenberg-mobile#5556.
Related PRs:
This PR incorporates a new version of Gutenberg Mobile which contain the upgrade Android 13. Additionally, in order to match the Aztec version between GB-Mobile and WPAndroid, the Aztec version has been updated too.
To test:
This change doesn't affect a specific area, hence to test it we should basically smoke test the editor and check that works as expected. We could also cover the writing flow test cases to ensure the basic actions of the editor work:
Click here to display testing instructions
General
Rich Text Format
Splitting and merging
Undo / Redo - Test Cases
Regression Notes
Potential unintended areas of impact
The classic editor.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: