-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: the jetpack migration issues #18612
Conversation
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr18612-14fff5d | |
Commit | 14fff5d | |
Direct Download | wordpress-prototype-build-pr18612-14fff5d.apk |
|
App Name | ![]() |
|
Flavor | Jalapeno | |
Build Type | Debug | |
Version | pr18612-14fff5d | |
Commit | 14fff5d | |
Direct Download | jetpack-prototype-build-pr18612-14fff5d.apk |
@AjeshRPai - The changes look good. Tested
|
Hey @zwarm
Sorry for this, I was testing on emulator on friday, I was able to reproduce it then. But I tested today on the emulator and physical device I cannot reproduce this issue. So all good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AjeshRPai - thank you for the additional check about the second button. All the fixes are ready to go. 🙇
Fixes
Phase dashboard
To test:
Phase 4 takes precedence over static posters phase
jp_removal_static_posters_phase
is onRegression Notes
Potential unintended areas of impact
Phase 4 ui is not shown correctly
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: