Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: the jetpack migration issues #18612

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Fixes: the jetpack migration issues #18612

merged 2 commits into from
Jun 19, 2023

Conversation

AjeshRPai
Copy link
Contributor

@AjeshRPai AjeshRPai commented Jun 16, 2023

Fixes

  • The incorrect precendence of static posters phase over phase 4
  • Incorrectly building stats, activitiy log and back up on phase 4

Phase dashboard

To test:

Phase 4 takes precedence over static posters phase

  • Login to wordpress app
  • navigate to debug settings
  • make sure the remote feature flag jp_removal_static_posters_phase is on
  • toggle the jp_removal_four
  • verify that the UI is as per the requirements
    • Activity log, back up and scan item is not shown
    • the reader/notifications tab is not shown

Regression Notes

  1. Potential unintended areas of impact
    Phase 4 ui is not shown correctly

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Sorry, something went wrong.

@AjeshRPai AjeshRPai requested a review from zwarm June 16, 2023 13:05
@AjeshRPai AjeshRPai self-assigned this Jun 16, 2023
@AjeshRPai AjeshRPai changed the base branch from release/22.6 to trunk June 16, 2023 13:14
@AjeshRPai AjeshRPai added this to the 22.7 milestone Jun 16, 2023
@AjeshRPai AjeshRPai changed the title Fixes: the jetpack migration issues in phase 4 Fixes: the jetpack migration issues Jun 16, 2023
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18612-14fff5d
Commit14fff5d
Direct Downloadwordpress-prototype-build-pr18612-14fff5d.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18612-14fff5d
Commit14fff5d
Direct Downloadjetpack-prototype-build-pr18612-14fff5d.apk
Note: Google Login is not supported on these builds.

@zwarm
Copy link
Contributor

zwarm commented Jun 16, 2023

@AjeshRPai - The changes look good.

Tested

  • Phase 4 takes precedence over static posters 👍
  • Stats, activity log, and backup do not show on Phase 4 👍
  • I was unable to reproduce the missing button; perhaps there is a particular sequence of flags that is causing this to happen. Can you provide additional information please.

@AjeshRPai AjeshRPai marked this pull request as ready for review June 19, 2023 07:41
@AjeshRPai
Copy link
Contributor Author

Hey @zwarm

  • i was unable to reproduce the missing button; perhaps there is a particular sequence of flags that is causing this to happen. can you provide additional information please.

Sorry for this, I was testing on emulator on friday, I was able to reproduce it then. But I tested today on the emulator and physical device I cannot reproduce this issue. So all good.

Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjeshRPai - thank you for the additional check about the second button. All the fixes are ready to go. 🙇

@zwarm zwarm merged commit 2672d55 into trunk Jun 19, 2023
@zwarm zwarm deleted the issue/p4-migration-issues branch June 19, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants