Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show privacy settings banner for users in GDPR jurisdictions #18696

Merged
merged 16 commits into from
Jun 26, 2023

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Jun 23, 2023

Fixes #18567

To test:

  1. Launch (either) app

  2. Login with a user from an EU country subject to GDPR (e.g. France)

  3. Expect to see the popup asking your consent

  4. Verify the events mentioned in this task are tracked

  5. Retry with an user from a non-GDPR country (e.g. US)

  6. Expect to not see the popup

  7. Restart the app after approving or denying consent

  8. Verify the popup is no longer shown

Regression Notes

  1. Potential unintended areas of impact
    First load of My Site dashboard.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    The new logic is covered by unit tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@mkevins mkevins changed the base branch from trunk to issue/18476-gdpr-compliance-requirement-check June 23, 2023 07:59
@ovitrif ovitrif self-requested a review June 23, 2023 15:54
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 23, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18696-91b0ba9
Commit91b0ba9
Direct Downloadwordpress-prototype-build-pr18696-91b0ba9.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 23, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18696-91b0ba9
Commit91b0ba9
Direct Downloadjetpack-prototype-build-pr18696-91b0ba9.apk
Note: Google Login is not supported on these builds.

@mkevins mkevins force-pushed the issue/18567-show-popover-for-eu-users branch from 449aea8 to de3c6fd Compare June 26, 2023 04:42
Base automatically changed from issue/18476-gdpr-compliance-requirement-check to trunk June 26, 2023 05:59
@ovitrif ovitrif closed this Jun 26, 2023
@ovitrif ovitrif deleted the issue/18567-show-popover-for-eu-users branch June 26, 2023 06:17
@ovitrif ovitrif restored the issue/18567-show-popover-for-eu-users branch June 26, 2023 06:21
@ovitrif ovitrif reopened this Jun 26, 2023
@ovitrif
Copy link
Contributor

ovitrif commented Jun 26, 2023

Ouch, I "closed" by mistake, glad I could reopen the PR

@ovitrif ovitrif marked this pull request as ready for review June 26, 2023 06:24
@ovitrif
Copy link
Contributor

ovitrif commented Jun 26, 2023

made ready for review as I will be focused on patching things if required, otherwise merging this PR

@mkevins
Copy link
Contributor Author

mkevins commented Jun 26, 2023

made ready for review as I will be focused on patching things if required, otherwise merging this PR

Thanks for your help on this Ovi!

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 26, 2023

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, I tested the happy flow and would merge this after testing and validating the unhappy flow 😅 , ie. the flow when it shouldn't be shown.

@ovitrif
Copy link
Contributor

ovitrif commented Jun 26, 2023

IMHO the landscape view isn't very much the best UX we can do:

But I won't block the merge just because of this. I will try to fix it on trunk, with another PR 👍🏻

All in all this is awesome work and many goodies added to the codebase, as well as solving the actual problem, and improving our compliance to the GDPR laws.

Thanks a million @mkevins for your effort on this work! 🙇🏻

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed my own patches and consider them appropriate. :trollface:

@ovitrif ovitrif enabled auto-merge June 26, 2023 10:41
@ovitrif
Copy link
Contributor

ovitrif commented Jun 26, 2023

Added 2 more patches and now enabled auto-merge for this:

  • I've added a fix to expand the bottom-sheet popup initial view on Landscape (see why).
  • 91b0ba9 to fix the failing UI test: e2eActivityLogCardNavigation

Preview with the patch for landscape: bab0115:

Land Port

@ovitrif ovitrif merged commit f283e00 into trunk Jun 26, 2023
@ovitrif ovitrif deleted the issue/18567-show-popover-for-eu-users branch June 26, 2023 11:01
@ovitrif ovitrif linked an issue Jun 26, 2023 that may be closed by this pull request
@mkevins
Copy link
Contributor Author

mkevins commented Jun 26, 2023

Thanks for all your help Ovi, and special thanks for wrangling the landscape issue and remaining failing test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android - Track user actions Android - Show popover for EU users
3 participants