-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gutenberg-mobile release 1.103.0 #19117
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me 🎊 ! I hold off on the approval until we update the release notes as mentioned here.
RELEASE-NOTES.txt
Outdated
@@ -4,6 +4,10 @@ | |||
----- | |||
* [*] The Zendesk ticket screen will be displayed for error dialogs resulting from account closure. [https://github.com/wordpress-mobile/WordPress-Android/pull/19023] | |||
* [***] [Jetpack-only] Contact Support: Need assistance? Use Jetpack mobile assistant for immediate help. Create a support ticket for further assistance. [https://github.com/wordpress-mobile/WordPress-Android/pull/18879] | |||
* [*] Block Editor: Fix crash when using the Search block TextInput in the block inserter [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6090] | |||
* [**] Block Editor: Add basic support to view, relocate, and remove the Jetpack Paywall block. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6076] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this would only affect the Jetpack app, so I'd add the [Jetpack-only]
tag to the entry. Additionally, I noticed there's an extra space that could be removed.
* [**] Block Editor: Add basic support to view, relocate, and remove the Jetpack Paywall block. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6076] | |
* [**] [Jetpack-only] Block Editor: Add basic support to view, relocate, and remove the Jetpack Paywall block. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6076] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, we'd also need to solve the file conflicts in the release notes file.
build.gradle
Outdated
@@ -20,7 +20,7 @@ ext { | |||
automatticRestVersion = '1.0.8' | |||
automatticStoriesVersion = '2.3.0' | |||
automatticTracksVersion = '3.2.0' | |||
gutenbergMobileVersion = 'v1.102.0' | |||
gutenbergMobileVersion = '6139-3025c34b5015f43884b697cb0cd80826c97138ce' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that this reference is not pointing to the latest commit of the Gutenberg Mobile PR, the SHA should be 273a193d6c0fcb05d09e1722902c8d985f089422
. Nevertheless, since the commits pushed after this reference only introduce an E2E test fix and update the release notes, we could directly use the release Git tag once we merge the Gutenberg PRs.
What do you think If I push the required changes for the approval along with the release tag? To save some time. 😅 |
Sure, this approach makes total sense to me (especially to save time 😅). |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
Found 1 violations: The PR caused the following dependency changes: \--- project :libs:editor
- \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.102.0
- +--- com.facebook.fresco:animated-gif:2.0.0
- | +--- com.parse.bolts:bolts-tasks:1.4.0
- | +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
- | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | \--- com.facebook.fresco:animated-base:2.0.0
- | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
- | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
- | +--- com.facebook.fresco:animated-drawable:2.0.0
- | | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
- | | +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
- | | \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | \--- com.parse.bolts:bolts-tasks:1.4.0
- +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
- +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
- | +--- com.google.android.exoplayer:exoplayer:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3
- | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | | \--- com.google.guava:guava:27.1-android
- | | | | +--- com.google.guava:failureaccess:1.0.1
- | | | | \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
- | | | \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
- | | +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
- | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
- | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
- | | \--- androidx.media:media:1.2.1 (*)
- | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
- | +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
- | +--- com.google.android.exoplayer:extension-okhttp:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
- | | \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.10.0 (*)
- | \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.10.0 (*)
- +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
- +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-4
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-get-random-values:1.4.0
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-safe-area-context:4.6.3
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.8.21 (*)
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-screens:3.22.0
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.8.21 (*)
- | +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
- | +--- androidx.fragment:fragment:1.3.6 -> 1.5.7 (*)
- | +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
- | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
- | +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
- | \--- androidx.core:core-ktx:1.5.0 -> 1.10.0 (*)
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-svg:13.9.0
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-webview:11.26.1
- | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.8.21 (*)
- | \--- androidx.webkit:webkit:1.4.0 -> 1.7.0 (*)
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-masked-view:0.2.9
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-clipboard:1.11.2
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-fast-image:8.5.11
- | +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
- | | +--- com.github.bumptech.glide:gifdecoder:4.15.1
- | | | \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
- | | +--- com.github.bumptech.glide:disklrucache:4.15.1
- | | +--- com.github.bumptech.glide:annotations:4.15.1
- | | +--- androidx.fragment:fragment:1.3.6 -> 1.5.7 (*)
- | | +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
- | | +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
- | | \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
- | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
- | +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
- | +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.10.0 (*)
- | \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-gesture-handler:2.10.2
- | +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
- | +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
- | +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.21 (*)
- +--- org.wordpress-mobile.react-native-libraries.v3:react-native-linear-gradient:2.7.3
- +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.102.0
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | +--- androidx.gridlayout:gridlayout:1.0.0
- | | +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
- | | \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
- | +--- androidx.cardview:cardview:1.0.0 (*)
- | +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
- | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
- | +--- org.wordpress:aztec:v1.6.4 -> v1.7.0 (*)
- | +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.4 -> v1.7.0 (*)
- | +--- org.wordpress.aztec:wordpress-comments:v1.6.4 -> v1.7.0 (*)
- | +--- org.wordpress.aztec:glide-loader:v1.6.4
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
- | | +--- org.wordpress:aztec:v1.6.4 -> v1.7.0 (*)
- | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
+ \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.103.0
+ +--- com.facebook.fresco:animated-gif:2.0.0
+ | +--- com.parse.bolts:bolts-tasks:1.4.0
+ | +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+ | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | \--- com.facebook.fresco:animated-base:2.0.0
+ | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+ | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+ | +--- com.facebook.fresco:animated-drawable:2.0.0
+ | | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+ | | +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+ | | \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | \--- com.parse.bolts:bolts-tasks:1.4.0
+ +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+ +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
+ | +--- com.google.android.exoplayer:exoplayer:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+ | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | | \--- com.google.guava:guava:27.1-android
+ | | | | +--- com.google.guava:failureaccess:1.0.1
+ | | | | \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+ | | | \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+ | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+ | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+ | | \--- androidx.media:media:1.2.1 (*)
+ | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+ | +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+ | +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+ | | \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.10.0 (*)
+ | \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.10.0 (*)
+ +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
+ +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-4
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-get-random-values:1.4.0
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-safe-area-context:4.6.3
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.8.21 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-screens:3.22.0
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.8.21 (*)
+ | +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
+ | +--- androidx.fragment:fragment:1.3.6 -> 1.5.7 (*)
+ | +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+ | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+ | +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
+ | \--- androidx.core:core-ktx:1.5.0 -> 1.10.0 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-svg:13.9.0
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-webview:11.26.1
+ | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.8.21 (*)
+ | \--- androidx.webkit:webkit:1.4.0 -> 1.7.0 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-masked-view:0.2.9
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-clipboard:1.11.2
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-fast-image:8.5.11
+ | +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
+ | | +--- com.github.bumptech.glide:gifdecoder:4.15.1
+ | | | \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+ | | +--- com.github.bumptech.glide:disklrucache:4.15.1
+ | | +--- com.github.bumptech.glide:annotations:4.15.1
+ | | +--- androidx.fragment:fragment:1.3.6 -> 1.5.7 (*)
+ | | +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+ | | +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
+ | | \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
+ | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+ | +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
+ | +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.10.0 (*)
+ | \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-gesture-handler:2.10.2
+ | +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
+ | +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
+ | +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.21 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v3:react-native-linear-gradient:2.7.3
+ +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.103.0
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | +--- androidx.gridlayout:gridlayout:1.0.0
+ | | +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
+ | | \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+ | +--- androidx.cardview:cardview:1.0.0 (*)
+ | +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
+ | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+ | +--- org.wordpress:aztec:v1.6.4 -> v1.7.0 (*)
+ | +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.4 -> v1.7.0 (*)
+ | +--- org.wordpress.aztec:wordpress-comments:v1.6.4 -> v1.7.0 (*)
+ | +--- org.wordpress.aztec:glide-loader:v1.6.4
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
+ | | +--- org.wordpress:aztec:v1.6.4 -> v1.7.0 (*)
+ | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.21 (*)
Please review and act accordingly
|
Description
This PR incorporates the 1.103.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#6139
Release Submission Checklist
RELEASE-NOTES.txt
if necessary.