-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CMM-953 fix reader subscribe when logged out #22370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMM-953 fix reader subscribe when logged out #22370
Conversation
Generated by 🚫 Danger |
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22370-7610fbd | |
| Commit | 7610fbd | |
| Direct Download | jetpack-prototype-build-pr22370-7610fbd.apk |
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22370-7610fbd | |
| Commit | 7610fbd | |
| Direct Download | wordpress-prototype-build-pr22370-7610fbd.apk |
dcalhoun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Testing worked as expected for me.
Improvement idea: if it's not too complex, would it make sense to subscribe the user to the targeted blog after they finish authenticating? If so, we might show a toast message with the ability to undo.
That's a good improvement! |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22370 +/- ##
==========================================
- Coverage 39.03% 39.02% -0.01%
==========================================
Files 2203 2203
Lines 106328 106340 +12
Branches 15059 15061 +2
==========================================
+ Hits 41500 41501 +1
- Misses 61338 61348 +10
- Partials 3490 3491 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|





Description
This PR is showing an informative message when the user is logged out and try to subscribe to a blog.
In addition to the message, we offer the option to open the login flow
Testing instructions
Test Case 1: Discovery Reader - Recommended Blogs
Test Case 2: Post Detail - Menu Subscribe
Screen_recording_20251126_175540.mp4
Screen_recording_20251126_175826.mp4