Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg - Fix unwanted bottom inset when keyboard is open #10727

Merged
merged 2 commits into from
Dec 27, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def shared_test_pods
end

def gutenberg_pod(name)
gutenberg_branch='master'
gutenberg_branch='issue/395-fix-content-bottom-inset-ios'
pod name, :podspec => "https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/#{gutenberg_branch}/react-native-gutenberg-bridge/third-party-podspecs/#{name}.podspec.json"
end

Expand All @@ -100,6 +100,7 @@ target 'WordPress' do
gutenberg_pod 'React'
gutenberg_pod 'yoga'
gutenberg_pod 'Folly'
gutenberg_pod 'react-native-safe-area'
pod 'RNSVG', :git => 'https://github.com/wordpress-mobile/react-native-svg.git', :tag => '8.0.9-gb.0'
pod 'RNTAztecView', :git => 'https://github.com/wordpress-mobile/react-native-aztec.git', :tag => 'v0.1.3'

Expand Down
23 changes: 16 additions & 7 deletions Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ PODS:
- Reachability (3.2)
- React (0.57.5):
- React/Core (= 0.57.5)
- react-native-safe-area (0.5.0):
- React
- React/Core (0.57.5):
- yoga (= 0.57.5.React)
- React/CxxBridge (0.57.5):
Expand Down Expand Up @@ -219,7 +221,7 @@ DEPENDENCIES:
- BuddyBuildSDK (= 1.0.17)
- CocoaLumberjack (= 3.4.2)
- Crashlytics (= 3.11.0)
- Folly (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/master/react-native-gutenberg-bridge/third-party-podspecs/Folly.podspec.json`)
- Folly (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/issue/395-fix-content-bottom-inset-ios/react-native-gutenberg-bridge/third-party-podspecs/Folly.podspec.json`)
- FormatterKit/TimeIntervalFormatter (= 1.8.2)
- Gifu (= 3.2.0)
- GiphyCoreSDK (~> 1.4.0)
Expand All @@ -236,7 +238,8 @@ DEPENDENCIES:
- OHHTTPStubs (= 6.1.0)
- OHHTTPStubs/Swift (= 6.1.0)
- Reachability (= 3.2)
- React (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/master/react-native-gutenberg-bridge/third-party-podspecs/React.podspec.json`)
- React (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/issue/395-fix-content-bottom-inset-ios/react-native-gutenberg-bridge/third-party-podspecs/React.podspec.json`)
- react-native-safe-area (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/issue/395-fix-content-bottom-inset-ios/react-native-gutenberg-bridge/third-party-podspecs/react-native-safe-area.podspec.json`)
- RNSVG (from `https://github.com/wordpress-mobile/react-native-svg.git`, tag `8.0.9-gb.0`)
- RNTAztecView (from `https://github.com/wordpress-mobile/react-native-aztec.git`, tag `v0.1.3`)
- SimulatorStatusMagic
Expand All @@ -250,7 +253,7 @@ DEPENDENCIES:
- WordPressUI (~> 1.1)
- WPMediaPicker (= 1.3.1)
- wpxmlrpc (= 0.8.3)
- yoga (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/master/react-native-gutenberg-bridge/third-party-podspecs/yoga.podspec.json`)
- yoga (from `https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/issue/395-fix-content-bottom-inset-ios/react-native-gutenberg-bridge/third-party-podspecs/yoga.podspec.json`)
- ZendeskSDK (= 2.2.0)

SPEC REPOS:
Expand Down Expand Up @@ -300,20 +303,22 @@ EXTERNAL SOURCES:
:git: https://github.com/Automattic/Automattic-Tracks-iOS.git
:tag: 0.2.3
Folly:
:podspec: https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/master/react-native-gutenberg-bridge/third-party-podspecs/Folly.podspec.json
:podspec: https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/issue/395-fix-content-bottom-inset-ios/react-native-gutenberg-bridge/third-party-podspecs/Folly.podspec.json
Gutenberg:
:git: http://github.com/wordpress-mobile/gutenberg-mobile/
:tag: v0.3.0
React:
:podspec: https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/master/react-native-gutenberg-bridge/third-party-podspecs/React.podspec.json
:podspec: https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/issue/395-fix-content-bottom-inset-ios/react-native-gutenberg-bridge/third-party-podspecs/React.podspec.json
react-native-safe-area:
:podspec: https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/issue/395-fix-content-bottom-inset-ios/react-native-gutenberg-bridge/third-party-podspecs/react-native-safe-area.podspec.json
RNSVG:
:git: https://github.com/wordpress-mobile/react-native-svg.git
:tag: 8.0.9-gb.0
RNTAztecView:
:git: https://github.com/wordpress-mobile/react-native-aztec.git
:tag: v0.1.3
yoga:
:podspec: https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/master/react-native-gutenberg-bridge/third-party-podspecs/yoga.podspec.json
:podspec: https://raw.githubusercontent.com/wordpress-mobile/gutenberg-mobile/issue/395-fix-content-bottom-inset-ios/react-native-gutenberg-bridge/third-party-podspecs/yoga.podspec.json

CHECKOUT OPTIONS:
Automattic-Tracks-iOS:
Expand All @@ -322,6 +327,9 @@ CHECKOUT OPTIONS:
Gutenberg:
:git: http://github.com/wordpress-mobile/gutenberg-mobile/
:tag: v0.3.0
react-native-safe-area:
:git: https://github.com/miyabi/react-native-safe-area.git
:tag: v0.5.0
RNSVG:
:git: https://github.com/wordpress-mobile/react-native-svg.git
:tag: 8.0.9-gb.0
Expand Down Expand Up @@ -360,6 +368,7 @@ SPEC CHECKSUMS:
OHHTTPStubs: 1e21c7d2c084b8153fc53d48400d8919d2d432d0
Reachability: 33e18b67625424e47b6cde6d202dce689ad7af96
React: 01aa04500b2957c2767e1dff9fe12e09444a467c
react-native-safe-area: 7dc92953fce43bf36ab5ecae2fb4ffa2bda9a203
RNSVG: 6d5813dd9c6a8e041e142abf1372faf012ce5759
RNTAztecView: 266ca6b864df41b55e942f23c4283a449a078af6
SimulatorStatusMagic: 0c0e711acef6e70dd8a0710962347635a9cdef24
Expand All @@ -377,6 +386,6 @@ SPEC CHECKSUMS:
yoga: f37b1edbd68be803f1dc4d57d40d8a5b277d8e2c
ZendeskSDK: 44ee00338dd718495f0364369420ae11b389c878

PODFILE CHECKSUM: e3e2fb4e1b6d8d1dfdc68b522a0a98ff0f565963
PODFILE CHECKSUM: 51f6a92febfea84b4b962e2b7dace6cae2d5deb3

COCOAPODS: 1.5.3
6 changes: 4 additions & 2 deletions WordPress/WordPress.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -4222,7 +4222,7 @@
name = Products;
sourceTree = "<group>";
};
29B97314FDCFA39411CA2CEA /* CustomTemplate */ = {
29B97314FDCFA39411CA2CEA = {
isa = PBXGroup;
children = (
F14B5F6F208E648200439554 /* config */,
Expand Down Expand Up @@ -8378,7 +8378,7 @@
bg,
sk,
);
mainGroup = 29B97314FDCFA39411CA2CEA /* CustomTemplate */;
mainGroup = 29B97314FDCFA39411CA2CEA;
productRefGroup = 19C28FACFE9D520D11CA2CBB /* Products */;
projectDirPath = "";
projectRoot = "";
Expand Down Expand Up @@ -8767,6 +8767,7 @@
"${PODS_ROOT}/ZendeskSDK/ZendeskSDK/4.2/ZendeskSDK.framework",
"${BUILT_PRODUCTS_DIR}/glog/glog.framework",
"${BUILT_PRODUCTS_DIR}/lottie-ios/Lottie.framework",
"${BUILT_PRODUCTS_DIR}/react-native-safe-area/react_native_safe_area.framework",
"${BUILT_PRODUCTS_DIR}/wpxmlrpc/wpxmlrpc.framework",
"${BUILT_PRODUCTS_DIR}/yoga/yoga.framework",
);
Expand Down Expand Up @@ -8809,6 +8810,7 @@
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/ZendeskSDK.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/glog.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Lottie.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/react_native_safe_area.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/wpxmlrpc.framework",
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/yoga.framework",
);
Expand Down