Improve upload on background

[SergioEstevao]

Related GB-Mobile PR: wordpress-mobile/gutenberg-mobile#576

This PR improves the use of thumbnails for image uploads to use the local cache images for Media. This is especially important when we have error states on background uploads.

To test:

• Create a post in GB
• Add an image to it
• Publish while the upload is going on
• Go back to post and see if the image shows up correctly
• Repeat but simulate an error while the upload is going on.

[etoledom]

Hey @SergioEstevao - With these changes, upload sync feels more robust, and I appreciate the higher thumb quality. 😁

I played quite a lot with it and it mostly behaves super good.
After a lot of making the upload fail, killing the app while updating and retrying many times, I managed to put the upload on a weird state, where the cell shows upload progress, but the image doesn't.

Here is a video showing this:
https://cloudup.com/csFj1y5noGl

But again, this happen after trying really hard to break it, and in general it works good!

Let me know if this issue is related to this PR or if you prefer to check it out on another PR to ✅ this one.

[SergioEstevao]

Hey @SergioEstevao - With these changes, upload sync feels more robust, and I appreciate the higher thumb quality. 😁

I played quite a lot with it and it mostly behaves super good.
After a lot of making the upload fail, killing the app while updating and retrying many times, I managed to put the upload on a weird state, where the cell shows upload progress, but the image doesn't.

Here is a video showing this:
https://cloudup.com/csFj1y5noGl

But again, this happen after trying really hard to break it, and in general it works good!

Let me know if this issue is related to this PR or if you prefer to check it out on another PR to ✅ this one.

I don't think it's related to this PR, it's more about Media states. It looks that sometimes the Media objects can get saved in incorrect states that makes think it's uploaded but it isn't.

[etoledom]

I don't think it's related to this PR

Cool to know that! :)

Let's wait until the WPiOS code freeze before merging this PR. It should be today.
I changed the milestone to 11.9.
cc @loremattei

[loremattei]

Thanks @etoledom! 10.8 code freeze is complete now, so you can merge this when you want.

[peril-wordpress-mobile]

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS