Gutenberg: Update gutenberg to use RN version 0.59.0 #11271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opent a PR to fix the Danger check: |
etoledom
added
Gutenberg
|
Danger check ready! Thank you @jtreanor ! |
SergioEstevao
approved these changes
Mar 14, 2019
|
Thank you @SergioEstevao ! |
|
@SergioEstevao - Updated to include the JS Bundles 👍 |
|
Looking great on iOS! It's a merge for me! |
|
Updated to the latest Merging this on ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes made on wordpress-mobile/gutenberg-mobile#741, meant to update React Native to 0.59.0
I made a few changes to Podfile to simplify future updates and to keep the react-native
podfile.jsondependencies always tagged, instead of pointing tomasterbranch (or branches in general).This will avoid problems where podfile keeps pointing to the same branch but the file itself was updated in that branch.
To test:
rake dependenciesgutenberg-mobilebranch and runmetroserver.Note: Since the JS Bundle haven't been updated yet, this won't work without metro running.