Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Hotfix 1.15.2 #12783

Merged
merged 12 commits into from
Oct 29, 2019
Merged

[Gutenberg] Hotfix 1.15.2 #12783

merged 12 commits into from
Oct 29, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 28, 2019 •
edited
Loading

PR to merge hotfix v1.15.2 into release/13.5

gutenberg-mobile PR: WordPress/gutenberg#18128

To test:

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Oct 28, 2019
@etoledom etoledom added this to the 13.5 ❄️ milestone Oct 28, 2019
@etoledom etoledom self-assigned this Oct 28, 2019
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 28, 2019 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@etoledom etoledom mentioned this pull request Oct 28, 2019
Merged
1 task
@etoledom etoledom marked this pull request as ready for review October 28, 2019 09:28
SergioEstevao
SergioEstevao approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Texted all the media flows and it's working well.

etoledom and others added 3 commits October 29, 2019 10:25
@etoledom
Update gutenberg ref
3e313af
@pinarol
Fix:Media & Text - Block validation error occurs if media upload fini…
16c74f6 
…shes when the post is closed (#12797)

* Update media-text mediaId when upload finishes for images

* Update media-text mediaId when upload finishes for videos

* Drop the `}` to match more cases for image and video blocks

* Update podfile.lock

* Revert "Update podfile.lock"

This reverts commit 3eb66c4.
@etoledom
Merge remote-tracking branch 'origin/release/13.5' into gutenberg/hot…
16a77ae 
…fix-1.15.2
@etoledom
Copy link
Contributor Author

Tested the last commit and overall looks good to me ✅

Somehow I managed to save a post with a media&text image local URL, but I wasn't able to reproduce this issue consistently.

The validation issue (from wordpress-mobile/gutenberg-mobile#1509) is completely gone and video uploads work just fine 🎉

pinarol
pinarol approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the test cases in the description + with image/video upload scenarios. LGTM 🎉

@koke
Copy link
Member

koke commented Oct 29, 2019

We already discussed this one, but making a note here:

  • Insert a media-text block
  • Choose to have the media on the right
  • Select an image and publish before it finishes uploading
  • The post is published with a local image URL and a local media ID

Interestingly enough, there is no validation error.

@koke
Copy link
Member

koke commented Oct 29, 2019

Not sure if I reported this before, but when you create a new post and insert a media-text block, the keyboard is set to lowercase instead of capitalizing the text.

IMG_43EC293B38BB-1

Also, the Content… placeholder is not showing translated, even though we have a translation for it.

@koke
Copy link
Member

koke commented Oct 29, 2019

I also noticed that our media upload process create intermediate undo steps, so after uploading an image on the image or media-text blocks, you can "undo" to get back to the local file or even the thumbnail. Switching to HTML and back would trigger a new upload (sometimes it happened right away).

undo-media-upload

It doesn't look like a new bug, as I can see the same in 13.5 (TestFlight)

@koke
Copy link
Member

koke commented Oct 29, 2019

Testing on iPhone 8 iOS 12.4.1 with Display Zoom enabled, the toggle for opening links in new tab is cropped:

IMG_38E40960D0AC-1

@mchowning mchowning merged commit b30ac20 into release/13.5 Oct 29, 2019
@mchowning mchowning deleted the gutenberg/hotfix-1.15.2 branch October 29, 2019 17:41
@etoledom
Copy link
Contributor Author

Thank you @koke for the detailed review!
Let's be sure to create the appropriate tickets for these issues 👍

This was referenced Nov 4, 2019
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

@etoledom etoledom

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
13.5
Development

Successfully merging this pull request may close these issues.
5 participants
@etoledom @koke @SergioEstevao @pinarol @mchowning