Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gutenberg empty fields with on RTL layout #14630

Closed
wants to merge 2 commits into from

Conversation

etoledom
Copy link
Contributor

Fixes #14477

gutenberg PR: WordPress/gutenberg#24510
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2544

RTL

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Aug 12, 2020
@etoledom etoledom added this to the 15.6 milestone Aug 12, 2020
@etoledom etoledom requested a review from guarani August 12, 2020 07:43
@etoledom etoledom self-assigned this Aug 12, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 12, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@etoledom etoledom force-pushed the gutenberg/fix-RTL-lang-empty-rich-text branch from 689e448 to 055b21f Compare August 12, 2020 08:05
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on sim with right-to-left pseudo-language and English, working well.
I'm curious to know why it wasn't working before, or why this sizeToFit fix is needed — but it does the job.

@mchowning
Copy link
Contributor

👋 @etoledom ! I'm thinking this PR isn't needed anymore because these changes would have been brought in with the 1.35.0 release. Does that sound right to you?

@etoledom
Copy link
Contributor Author

👋 @etoledom ! I'm thinking this PR isn't needed anymore because these changes would have been brought in with the 1.35.0 release. Does that sound right to you?

That's exactly true!
Closing

@etoledom etoledom closed this Aug 24, 2020
@etoledom etoledom deleted the gutenberg/fix-RTL-lang-empty-rich-text branch August 31, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add title and editor looks blank in RTL
3 participants