Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic structure for unified prologue content views #16153

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

frosty
Copy link
Contributor

@frosty frosty commented Mar 23, 2021

Ref #15056

This PR implements a basic structure for adding content views to the new unified prologue. It simply adds some code to add ContentView UIView subclasses to the main carousel for each page, with a skeleton implementation of the intro screen's content view.

Note that the contents of the intro screen isn't final, just a placeholder – but this PR is just to allow us to start working on the other screens in parallel.

To test

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @frosty , thank you for this!

I know it's not final and the feature flag is disabled, but wanted to point out that the views/constraints will need to be adjusted to fit the iPad too. Here's what it looks as of now, compared to what we have in the designs

design actual

Approving this one so we can move forward and make the changes.

@frosty
Copy link
Contributor Author

frosty commented Mar 24, 2021

Thanks! Yep, definitely needs lots of adjustment for iPad!

@frosty frosty merged commit 3daab69 into develop Mar 24, 2021
@frosty frosty deleted the feature/prologue-page-content-view branch March 24, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants