-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified prologue - Stats screen #16187
Conversation
- Also add new UnifiedPrologueStatsContentView
…rologueEditorContentView
…rologueStatsContentView
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! If I was going to nitpick against the original designs I would say:
- The purple face icon could be a little lower and perhaps a little bigger
- The people icon could be a little bigger too
- The chart element could be a little taller (the map may want to be a little less tall to account for this)
But these are all very minor.
- Also, on iPhone 12 Pro this content view appears a little lower than the editor content view – I think because the title runs over 3 lines instead of 2. Again, this might be something we address separately.
@@ -75,9 +75,14 @@ class UnifiedProloguePageViewController: UIViewController { | |||
private func configureContentView() { | |||
contentView.translatesAutoresizingMaskIntoConstraints = false | |||
view.addSubview(contentView) | |||
|
|||
let contentViewHeight: CGFloat | |||
if let windowHeight = UIApplication.shared.mainWindow?.frame.height { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure about using the main window, as this isn't very future proof if we support multiple scenes / windows in the future? Also if the window size changes (for example rotating an iPad)?
Thanks for reviewing @frosty
sizes and positions changed.
Agreed to fix these in a separate PR. |
…ss-iOS into feature/prologue-stats-screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…ss-iOS into feature/prologue-stats-screen
Ref #15056
NOTE: this PR calculates the distance between the prologue title and the content view relative to the actual view height, and removes the
Spacer
above and below the SwiftUI view. As a consequence, if we follow this approach, other prologue pages need to be updatedTo test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.