Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Start: Display modal after login if default section is Home #18721

Merged
merged 4 commits into from
May 26, 2022
Merged

Quick Start: Display modal after login if default section is Home #18721

merged 4 commits into from
May 26, 2022

Conversation

hassaanelgarem
Copy link
Contributor

Fixes #18566

Description

Quick Start modal was only being displayed after login if the assigned default tab is Menu. This PR adds the same behaviour to user with default tab Home.

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2022-05-25.at.00.34.21.mp4

Testing Instructions

  1. Replace the implementation of BlogDashboardAB.calculateVariant() with return .treatment
  2. Install and run the app
  3. Log in then and choose "show me around"
  4. Make sure that the quick start modal is presented

Regression Notes

  1. Potential unintended areas of impact
    Removing quick start cards and updating quick start cards when "Initial Screen" changes

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added this to the 20.0 milestone May 24, 2022
@hassaanelgarem hassaanelgarem self-assigned this May 24, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 24, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18721-2ad8d86 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 24, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18721-2ad8d86 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

momo-ozawa
momo-ozawa approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Can you also mention this in the release notes? I'm thinking probably an [internal] note should be fine.

@hassaanelgarem
Copy link
Contributor Author

Can you also mention this in the release notes? I'm thinking probably an [internal] note should be fine.

Good point! Added in 62bb58e 👍

@hassaanelgarem hassaanelgarem merged commit 38fed08 into trunk May 26, 2022
@hassaanelgarem hassaanelgarem deleted the issue/18566-qs-modal-login-home branch May 26, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

Assignees

@hassaanelgarem hassaanelgarem

Labels
[Type] Bug
Projects
None yet
Milestone
20.0
Development

Successfully merging this pull request may close these issues.

QuickStart: Modal not presented after login if default tab is Home
3 participants
@hassaanelgarem @wpmobilebot @momo-ozawa