-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Upgrade React Native 0.71.11
#20956
Commits on Jul 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b7fd735 - Browse repository at this point
Copy the full SHA b7fd735View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27e6b3f - Browse repository at this point
Copy the full SHA 27e6b3fView commit details -
No other than reason than me looking at the CocoaPods setup and realizing we were a few versions behind.
Configuration menu - View commit details
-
Copy full SHA for 22334c5 - Browse repository at this point
Copy the full SHA 22334c5View commit details -
Switch to tar.gz for the Gutenberg XCFramework archive
Despite it working during the prototype stage, I wasn't able to get the XCFrameworks out of the ZIP archive, but it works fine with the tar.gz. I suspect this has to do with the folder(s) generated when decompressing.
Configuration menu - View commit details
-
Copy full SHA for aca165e - Browse repository at this point
Copy the full SHA aca165eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 211b497 - Browse repository at this point
Copy the full SHA 211b497View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aa0487 - Browse repository at this point
Copy the full SHA 0aa0487View commit details -
Add a couple of newly required
import React
These are unnecessary at the moment but will be when we move to Gutenberg via XCFramework
Configuration menu - View commit details
-
Copy full SHA for dffeb71 - Browse repository at this point
Copy the full SHA dffeb71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1acc425 - Browse repository at this point
Copy the full SHA 1acc425View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8176593 - Browse repository at this point
Copy the full SHA 8176593View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d31186 - Browse repository at this point
Copy the full SHA 7d31186View commit details -
Remove
pre_install
download hook in favor ofprepare_command
The advantage of this approach is that downloading the archive is only necessary when using a local spec. Defining the logic in the local spec itself keeps everything self contained and saves us from having to conditionally call the `pre_install` hook.
Configuration menu - View commit details
-
Copy full SHA for 27186a2 - Browse repository at this point
Copy the full SHA 27186a2View commit details -
Use remote spec instead of a local one for Gutenberg via commit
The idea was to use a local spec and interpolated the desired commit SHA1 in the `source` to download the corresponding `tar.gz`. However, CocoaPods has some issues with local specs that use `http` `source`, as documented in: - CocoaPods/CocoaPods#10288 (comment) - https://github.com/firebase/firebase-ios-sdk/blob/68b39b8edf61f6e643e2396e712c7c67e0f146ff/scripts/pod_lib_lint.rb#L70-L78 Using a remote spec doesn't have the same issue, and the cost in terms of extra computation and storage is negligible when compared to building and hosting the `tar.gz` archives.
Configuration menu - View commit details
-
Copy full SHA for a4c6070 - Browse repository at this point
Copy the full SHA a4c6070View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11b0d2c - Browse repository at this point
Copy the full SHA 11b0d2cView commit details -
This was done to address the following CI failure when building with the Gutenberg XCFramework: ``` ▸ Linking WordPress
⚠️ ld: Could not find or use auto-linked library 'swiftCompatibility56' ❌ ld: symbol(s) not found for architecture x86_64 ``` https://buildkite.com/automattic/wordpress-ios/builds/14356#01885545-c05a-43a8-b475-d0d683857672Configuration menu - View commit details
-
Copy full SHA for 64ac588 - Browse repository at this point
Copy the full SHA 64ac588View commit details -
Configuration menu - View commit details
-
Copy full SHA for ede6c5d - Browse repository at this point
Copy the full SHA ede6c5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0806f9b - Browse repository at this point
Copy the full SHA 0806f9bView commit details -
Do not
@testable import
Gutenberg in unit testsBecause the latest XCFramework setup ships without testing compilation.
Configuration menu - View commit details
-
Copy full SHA for dfae970 - Browse repository at this point
Copy the full SHA dfae970View commit details -
DRY logic setting Gutenberg URL when using tag or commit
Co-authored-by: Tony Li <tony.li@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 4726973 - Browse repository at this point
Copy the full SHA 4726973View commit details -
Simplify
gutenberg_dependencies
with early returnCo-authored-by: Tony Li <tony.li@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for c2c46cc - Browse repository at this point
Copy the full SHA c2c46ccView commit details
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 59d7b78 - Browse repository at this point
Copy the full SHA 59d7b78View commit details -
Configuration menu - View commit details
-
Copy full SHA for d03be58 - Browse repository at this point
Copy the full SHA d03be58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fcd1b5 - Browse repository at this point
Copy the full SHA 3fcd1b5View commit details
Commits on Jul 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b6b8d9c - Browse repository at this point
Copy the full SHA b6b8d9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6dd34e - Browse repository at this point
Copy the full SHA d6dd34eView commit details
Commits on Jul 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d81f466 - Browse repository at this point
Copy the full SHA d81f466View commit details
Commits on Jul 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f875968 - Browse repository at this point
Copy the full SHA f875968View commit details -
Merge branch 'trunk' into mokagio/gutenberg-xcframework-setup
# Conflicts: # Podfile.lock
Configuration menu - View commit details
-
Copy full SHA for 9192af0 - Browse repository at this point
Copy the full SHA 9192af0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 381d49a - Browse repository at this point
Copy the full SHA 381d49aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ebd4cca - Browse repository at this point
Copy the full SHA ebd4ccaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b1138f - Browse repository at this point
Copy the full SHA 2b1138fView commit details -
Merge and fix pre-install logic into
gutenberg_dependencies
blockThe pre-install logic is only needed when using local Gutenberg installation. Hence, we can merge it into the `gutenberg_dependencies`, which is only used in that case. Additionally, the React Native modules path has been fixed to point to the local installation. Fix empty line after guard clause lint issue
Configuration menu - View commit details
-
Copy full SHA for 65e5454 - Browse repository at this point
Copy the full SHA 65e5454View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d40a68 - Browse repository at this point
Copy the full SHA 2d40a68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 598b038 - Browse repository at this point
Copy the full SHA 598b038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 341f617 - Browse repository at this point
Copy the full SHA 341f617View commit details -
Configuration menu - View commit details
-
Copy full SHA for 551968e - Browse repository at this point
Copy the full SHA 551968eView commit details -
Reintroduce link to internal doc with "Do Not Embed" explanation
Co-authored-by: Olivier Halligon <olivier.halligon@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 723f8ed - Browse repository at this point
Copy the full SHA 723f8edView commit details
Commits on Jul 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9ceb947 - Browse repository at this point
Copy the full SHA 9ceb947View commit details -
Configuration menu - View commit details
-
Copy full SHA for e39537b - Browse repository at this point
Copy the full SHA e39537bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4530832 - Browse repository at this point
Copy the full SHA 4530832View commit details -
Merge pull request #21143 from wordpress-mobile/test/latest-wip-xcfra…
…mework-and-ui-tests Fix failing UI tests after React Native upgrade in Gutenberg
Configuration menu - View commit details
-
Copy full SHA for 170d7f4 - Browse repository at this point
Copy the full SHA 170d7f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4fe6e8 - Browse repository at this point
Copy the full SHA a4fe6e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7cf5c3 - Browse repository at this point
Copy the full SHA d7cf5c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4945d03 - Browse repository at this point
Copy the full SHA 4945d03View commit details
Commits on Jul 21, 2023
-
Merge remote-tracking branch 'origin/trunk' into gutenberg/upgrade/re…
Configuration menu - View commit details
-
Copy full SHA for 795a9c2 - Browse repository at this point
Copy the full SHA 795a9c2View commit details -
Merge branch 'mokagio/gutenberg-xcframework-setup' into gutenberg/upg…
…rade/react-native-0.71.11
Configuration menu - View commit details
-
Copy full SHA for 64811c6 - Browse repository at this point
Copy the full SHA 64811c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c992bcb - Browse repository at this point
Copy the full SHA c992bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e11b1e - Browse repository at this point
Copy the full SHA 7e11b1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ce7fdc - Browse repository at this point
Copy the full SHA 6ce7fdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59b6bb3 - Browse repository at this point
Copy the full SHA 59b6bb3View commit details -
Merge branch 'trunk' into gutenberg/upgrade/react-native-0.71.11
# Conflicts: # Gutenberg/version.rb # Podfile.lock
Configuration menu - View commit details
-
Copy full SHA for 8c8f945 - Browse repository at this point
Copy the full SHA 8c8f945View commit details
Commits on Jul 27, 2023
-
Merge branch 'trunk' of github.com:wordpress-mobile/WordPress-iOS int…
…o gutenberg/upgrade/react-native-0.71.11
Configuration menu - View commit details
-
Copy full SHA for e39dfaf - Browse repository at this point
Copy the full SHA e39dfafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12164fc - Browse repository at this point
Copy the full SHA 12164fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4642cfb - Browse repository at this point
Copy the full SHA 4642cfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 131057d - Browse repository at this point
Copy the full SHA 131057dView commit details -
Merge branch 'trunk' into gutenberg/upgrade/react-native-0.71.11
# Conflicts: # WordPress/WordPress.xcodeproj/project.pbxproj
Configuration menu - View commit details
-
Copy full SHA for 812b034 - Browse repository at this point
Copy the full SHA 812b034View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40541ae - Browse repository at this point
Copy the full SHA 40541aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66ad340 - Browse repository at this point
Copy the full SHA 66ad340View commit details