Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize commands to config Sim in UI tests in aggregate target #21192

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jul 27, 2023

By moving them in an aggregate target on which the UI tests targets depend, we DRY the setup as well as making the existence of this capability more visible (in the targets list instead of buried in the build phases).

Having the commands in a separate script file also makes it easier to inspect diffs and working on them, given that the Xcode build phase script editor window is far from a good text interface for coding.

Testing

If the UI tests pass in CI, we're good.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

By moving them in an aggregate target on which the UI tests targets
depend, we DRY the setup as well as making the existence of this
capability more visible (in the targets list instead of buried in the
build phases).

Having the commands in a separate script file also makes it easier to
inspect diffs and working on them, given that the Xcode build phase
script editor window is far from a good text interface for coding.
@mokagio mokagio force-pushed the mokagio/centralize-simulator-reset branch from e8c611e to 8badab3 Compare July 27, 2023 04:22
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21192-8badab3
Version22.9
Bundle IDcom.jetpack.alpha
Commit8badab3
App Center Buildjetpack-installable-builds #5544
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21192-8badab3
Version22.9
Bundle IDorg.wordpress.alpha
Commit8badab3
App Center BuildWPiOS - One-Offs #6512
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio requested a review from a team July 27, 2023 05:22
@mokagio mokagio added the Testing Unit and UI Tests and Tooling label Jul 27, 2023
@mokagio mokagio added this to the 23.0 milestone Jul 27, 2023
@mokagio mokagio enabled auto-merge July 27, 2023 05:23
Copy link
Contributor

@jostnes jostnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @mokagio! It'll definitely be easier to monitor current configurations with this script, for example, I wasn't aware that this was the current setting

# Disable the hardware keyboard in the Simulator
defaults write com.apple.iphonesimulator ConnectHardwareKeyboard -bool false

CI is 🟢 looks good to :shipit:

One question - will the same be done for the WCiOS project?

@mokagio mokagio merged commit eb05889 into trunk Jul 27, 2023
@mokagio mokagio deleted the mokagio/centralize-simulator-reset branch July 27, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Unit and UI Tests and Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants