Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] - Fixes font customization not getting updated #21269

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Aug 7, 2023

Related PRs:

This PR fixes an issue that started to happen after the recent React Native upgrade where the post title and some other functionality related to custom font size and font styles like bold formatting wouldn't work as expected.

To test check the Gutenberg PR description.

Regression Notes

  1. Potential unintended areas of impact
    Editor

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing, CI automated tests.

  3. What automated tests I added (or what prevented me from doing so)
    None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@geriux geriux added [Status] In Progress Gutenberg Editing and display of Gutenberg blocks. labels Aug 7, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 7, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21269-6db9495
Version23.0
Bundle IDcom.jetpack.alpha
Commit6db9495
App Center Buildjetpack-installable-builds #5770
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 8, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21269-6db9495
Version23.0
Bundle IDorg.wordpress.alpha
Commit6db9495
App Center BuildWPiOS - One-Offs #6733
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@geriux geriux force-pushed the gutenberg/ios-font-customization branch from 6f98b54 to c6fc320 Compare August 8, 2023 18:31
@twstokes twstokes self-requested a review August 9, 2023 21:26
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via this comment.

@geriux geriux merged commit 36ecb3c into trunk Aug 16, 2023
@geriux geriux deleted the gutenberg/ios-font-customization branch August 16, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants