Remove image optimization pop-up

[SiobhyB]

Description:

The pop-up that displays when users first upload an image is removed with this PR.

The pop-up was designed to inform users about the optimization settings available under Me → App Settings, however, we received feedback about it contributing to an overall confusing experience. Following internal discussion, we've made a decision to remove the pop-up following and will consider other ways to make the optimization settings discoverable.

• Internal ref: p9ugOq-4nG-p2
• Android equivalent: Remove image optimization pop-up WordPress-Android#20045

---

To Test:

We should verify that uploads continue to function as expected when uploading media through the various available flows.

Media Screen

• Navigate to My Site → Media.
• Tap on ➕ button and select Choose from My Device option.
• Select one or multiple items.
• Tap on the Add button.
• Verify the upload works as expected.

Gutenberg → Media Blocks from Device

• Navigate to My Site → Posts (or Pages).
• Create a new post or edit an existing one.
• Add any of the following blocks:
  • Image block
  • Gallery block
  • Cover block
  • Media & Text block
• Tap on the Choose from device option.
• Select one item (or multiple items when using Gallery block).
• Verify the upload works as expected.

Gutenberg → Media Blocks via Taking a Photo

• Navigate to My Site → Posts (or Pages).
• Create a new post or edit an existing one.
• Add any of the following blocks:
  • Image block
  • Gallery block
  • Cover block
  • Media & Text block
• Tap on the Take a Photo option.
• Take a photo.
• Verify the upload works as expected.

Featured Image from Device

• Tap on the ... button located in the editor's top bar.
• Tap on the Post Settings options.
• Navigate to the Featured Image section and tap on Set Featured Image.
• Tap on the Choose from Device option.
• Select one time.
• Verify the upload works as expected.

Featured Image via Taking a Photo

• Tap on the ... button located in the editor's top bar.
• Tap on the Post Settings options.
• Navigate to the Featured Image section and tap on Set Featured Image.
• Tap on the Take a Photo option.
• Take a photo.
• Verify the upload works as expected.

---

Regression Notes

1. Potential unintended areas of impact

   • It would be unintended to change anything about the media upload flow other than removing the image optimization pop-up.

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Relied on existing tests around media uploads, as well as manual testing.

3. What automated tests I added (or what prevented me from doing so)

   • As this PR didn't add new functionality around media uploads, I didn't deem it necessary to add new tests. Instead, I trusted that any potential regressions caused by removing the pop-up would be caught with either the existing tests or through manually testing the upload flows.

---

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 24.1 ❄️. The due date for this milestone has already passed. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22476-563ec2f
	Version	24.1
	Bundle ID	org.wordpress.alpha
	Commit	563ec2f
	App Center Build	WPiOS - One-Offs #8547

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22476-563ec2f
	Version	24.1
	Bundle ID	com.jetpack.alpha
	Commit	563ec2f
	App Center Build	jetpack-installable-builds #7574

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[fluiddot]

LGTM 🎊 !

I confirmed that the pop-up is no longer being displayed on a fresh install, as well as that the upload flow works as expected.

Tested on an iPhone 11 (iOS 17.0.2).