Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release v1.112.0 #22513

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

derekblank
Copy link
Contributor

Description

This PR incorporates the 1.112.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#6597

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@derekblank derekblank added the Gutenberg Editing and display of Gutenberg blocks. label Feb 1, 2024
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 1, 2024

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@derekblank derekblank added this to the 24.2 milestone Feb 1, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 1, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22513-8e8c5b4
Version24.1
Bundle IDcom.jetpack.alpha
Commit8e8c5b4
App Center Buildjetpack-installable-builds #7672
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 1, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22513-8e8c5b4
Version24.1
Bundle IDorg.wordpress.alpha
Commit8e8c5b4
App Center BuildWPiOS - One-Offs #8644
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the Release Submission Checklist in the PR:

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

It would be interesting to check if this release introduced user-facing changes (e.g. Fix crash occurring on large post on Android) and if so, reflect it.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

NOTE: Before merging this PR, we need to update the Gutenberg Mobile reference to point to the release tag. Besides, we could review the release notes as mentioned in #22513 (review).

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.2. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@derekblank derekblank merged commit 69e8ebc into trunk Feb 2, 2024
22 checks passed
@derekblank derekblank deleted the gutenberg/integrate_release_1.112.0 branch February 2, 2024 04:09
Comment on lines +3 to +4
* [**] Prevent images from temporarily disappearing when uploading media [https://github.com/WordPress/gutenberg/pull/57869]
* [**] Fix crash occurring on large post on Android [https://github.com/WordPress/gutenberg/pull/58266]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekblank Similar to wordpress-mobile/WordPress-Android#20093 (review), we could add more detail to the release notes by adding the prefix Block Editor: for entries related to the editor (example).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I completely overlooked that this entry shouldn't be included as it's an Android-only one. Fortunately, it was fixed in #22562. Thanks 🙇 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants