Stats: Fix a crash in a remote service when accessing date formatter

[staskus]

Fixes #22796
Related PR: wordpress-mobile/WordPressKit-iOS#749

I couldn't reproduce the issue myself. Analysis of the stack trace suggests that the crash may have happened due to the date formatter being accessed from different threads and/or objects being deinitialized when being accessed. Although it's not 100% clear what exact changes in Stats made this issue happen. It could be triggered by some of the updates within StatsPeriodStore.

More information here wordpress-mobile/WordPressKit-iOS#749

Testing

The changes are in getData method which is used when fetching chart information within Traffic or Day/Week/Month/Year Stats. They are only technical changes but the data for the chart should continue to be loaded.

Regression Notes

1. Potential unintended areas of impact

None

2. What I did to test those areas of impact (or what existing automated tests I relied on)

Currently existing automated tests and manual testing

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22810-4c4bffc
	Version	24.4
	Bundle ID	org.wordpress.alpha
	Commit	4c4bffc
	App Center Build	WPiOS - One-Offs #9151

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22810-4c4bffc
	Version	24.4
	Bundle ID	com.jetpack.alpha
	Commit	4c4bffc
	App Center Build	jetpack-installable-builds #8195

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[guarani]

Approved via wordpress-mobile/WordPressKit-iOS#749 (review)