[Site Switcher] Older version search fix #23212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed that `configureStreamHeader()` had too many layout constraints juggling, so this simplifies it a bit. * `ReaderSiteHeaderView` now inherits from `UITableViewHeaderFooterView`, so that it has the same readableContentGuide of table views. This removes the need to put the SwiftUI view in a container view and align the horizontal anchors manually to the table view. * Moved the border-adding logic to each own views.
This is a workaround that avoids unsatisfiable constraint warnings in the console. By reducing the constraint priority to 999, this allows the the layout engine to prioritize the constraints from `UIView-Encapsulated-Layout-Width` (or height).
The `configureStreamHeader()` method is currently only called when the `readerTopic` is not nil. This needs to be modified because there are streams without a topic (Saved, Tags).
Generated by 🚫 Danger |
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23212-1170a72 | |
| Version | 24.9 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 1170a72 | |
| App Center Build | WPiOS - One-Offs #9907 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23212-1170a72 | |
| Version | 24.9 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 1170a72 | |
| App Center Build | jetpack-installable-builds #8957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##23209
Description
Fixes the the new site picker's search not working issue on versions prior to iOS 17.0
Testing Steps
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: