Skip to content

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Sep 25, 2024

Description

Gracefully handle failed attempts to load a site's remote editor by falling back
to the local, default editor and displaying a notice to the user.

Related:

To test: See wordpress-mobile/GutenbergKit#27.

Regression Notes

  1. Potential unintended areas of impact
    None, should be limited to the experimental editor.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A.
  3. What automated tests I added (or what prevented me from doing so)
    None, we are not focused on automating tests for this experimental feature.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Sep 25, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 25, 2024

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 25, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23624-eebbbfa
Version25.4
Bundle IDcom.jetpack.alpha
Commiteebbbfa
App Center Buildjetpack-installable-builds #9881
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 25, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23624-eebbbfa
Version25.4
Bundle IDorg.wordpress.alpha
Commiteebbbfa
App Center BuildWPiOS - One-Offs #10839
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun marked this pull request as ready for review September 25, 2024 13:29
@dcalhoun dcalhoun requested a review from geriux September 25, 2024 13:29
@dcalhoun dcalhoun removed the request for review from geriux October 17, 2024 18:59
@dcalhoun dcalhoun force-pushed the feat/handle-remote-editor-load-failure branch from 40efb07 to 3ab813e Compare October 17, 2024 19:09
@dcalhoun dcalhoun requested a review from kean October 17, 2024 20:02
@dcalhoun dcalhoun enabled auto-merge October 21, 2024 15:57
@dcalhoun dcalhoun added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@dcalhoun dcalhoun added this pull request to the merge queue Oct 21, 2024
Merged via the queue into trunk with commit 0a723f0 Oct 21, 2024
@dcalhoun dcalhoun deleted the feat/handle-remote-editor-load-failure branch October 21, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants