-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Handle remote editor load failure #23624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23624-eebbbfa | |
| Version | 25.4 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | eebbbfa | |
| App Center Build | jetpack-installable-builds #9881 |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23624-eebbbfa | |
| Version | 25.4 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | eebbbfa | |
| App Center Build | WPiOS - One-Offs #10839 |
40efb07 to
3ab813e
Compare
kean
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
Gracefully handle failed attempts to load a site's remote editor by falling back
to the local, default editor and displaying a notice to the user.
Related:
To test: See wordpress-mobile/GutenbergKit#27.
Regression Notes
None, should be limited to the experimental editor.
N/A.
None, we are not focused on automating tests for this experimental feature.
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: