Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract delete user confirmation sheet into its own view #23835

Open
wants to merge 2 commits into
base: move-application-passwords-list-entry
Choose a base branch
from

Conversation

crazytonyli
Copy link
Contributor

Note

This PR is built on top of #23834.

Nothing too interesting really. Just moving a ViewBuilder function to a View type.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.6 milestone Nov 20, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 20, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23835-cfbb870
Version25.4.2
Bundle IDorg.wordpress.alpha
Commitcfbb870
App Center BuildWPiOS - One-Offs #11124
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 20, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23835-cfbb870
Version25.4.2
Bundle IDcom.jetpack.alpha
Commitcfbb870
App Center Buildjetpack-installable-builds #10164
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean
Copy link
Contributor

kean commented Nov 20, 2024

The current form look a bit off.

Screenshot 2024-11-20 at 8 55 21 AM

Id suggest the following changes (not necessarily in the scope of this PR):

  • Shorter title for the field and remove :
  • Push list of users in the navigation stack + use the same design and maybe even code to render the post list
  • Smaller spacing for the header
Screenshot 2024-11-20 at 8 37 07 AM
        Form {
            Section {
                NavigationLink {
                    EmptyView()
                } label: {
                    HStack {
                        Text("Selected User")
                        Spacer()
                        Text("username2")
                            .foregroundStyle(.secondary)
                    }

                }
            } header: {
                Text("Select the user to attribute the content of the site to")
                    .font(.body)
                    .textCase(nil)
                    .foregroundStyle(.primary)
                    .padding(.bottom, 8)
            }
        }

@crazytonyli
Copy link
Contributor Author

crazytonyli commented Nov 24, 2024

@kean Thanks for the suggestion. I have update the UI to also include a short helper message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants